Siddhesh Poyarekar has uploaded this change for review. (
https://gem5-review.googlesource.com/8563
Change subject: dev: Don't fall through into BRAR after RFDR case
......................................................................
dev: Don't fall through into BRAR after RFDR case
If the switch block inside the RFDR case selects the non-default case
and breaks out, it will fall through into the BRAR case, which seems
incorrect. Put in a break to ensure that it breaks out of the parent
switch block as well.
Change-Id: Ie4cedf66954b7e8f4b884ad9e3a653968bbfaef7
Signed-off-by: Siddhesh Poyarekar <[email protected]>
---
M src/dev/net/ns_gige.cc
1 file changed, 1 insertion(+), 0 deletions(-)
diff --git a/src/dev/net/ns_gige.cc b/src/dev/net/ns_gige.cc
index dbed29f..e1289b4 100644
--- a/src/dev/net/ns_gige.cc
+++ b/src/dev/net/ns_gige.cc
@@ -742,6 +742,7 @@
panic("writing RFDR for something other than pattern
matching "
"or hashing! %#x\n", rfaddr);
}
+ break;
case BRAR:
regs.brar = reg;
--
To view, visit https://gem5-review.googlesource.com/8563
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie4cedf66954b7e8f4b884ad9e3a653968bbfaef7
Gerrit-Change-Number: 8563
Gerrit-PatchSet: 1
Gerrit-Owner: Siddhesh Poyarekar <[email protected]>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
