Hello Andreas Sandberg,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/12472
to review the following change.
Change subject: config, dev-arm: Fix UART handling baremetal mode
......................................................................
config, dev-arm: Fix UART handling baremetal mode
fs.py in baremetal mode currently fails for the VExpress_GEM5_V1 platform
due to inconsistent UART naming with error message:
AttributeError: object 'VExpress_GEM5_V1' has no attribute 'uart'
Consistently name keep all UARTs in the Arm platforms in a vector named
'uart' or as a single device named 'uart'. Update the configuration
scripts to reflect the fact that 'uart' can be a vector.
Change-Id: I20b8dbac794d6a9be19b6ce8c335a097872132fb
Reviewed-on: https://eu-gerrit-1.euhpc.arm.com/146267
Style-Check: Gerrit Service Bot <[email protected]>
Copyright-Check: Gerrit Service Bot <[email protected]>
Reviewed-by: Andreas Sandberg <[email protected]>
For-Upstream: Andreas Sandberg <[email protected]>
---
M configs/common/FSConfig.py
M src/dev/arm/RealView.py
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/configs/common/FSConfig.py b/configs/common/FSConfig.py
index 17498c4..aa00efe 100644
--- a/configs/common/FSConfig.py
+++ b/configs/common/FSConfig.py
@@ -304,7 +304,7 @@
if bare_metal:
# EOT character on UART will end the simulation
- self.realview.uart.end_on_eot = True
+ self.realview.uart[0].end_on_eot = True
else:
if machine_type in default_kernels:
self.kernel = binary(default_kernels[machine_type])
diff --git a/src/dev/arm/RealView.py b/src/dev/arm/RealView.py
index 837f798..cc77f23 100644
--- a/src/dev/arm/RealView.py
+++ b/src/dev/arm/RealView.py
@@ -1138,7 +1138,9 @@
clock24MHz = SrcClockDomain(clock="24MHz",
voltage_domain=VoltageDomain(voltage="3.3V"))
- uart0 = Pl011(pio_addr=0x1c090000, int_num=37)
+ uart = [
+ Pl011(pio_addr=0x1c090000, int_num=37),
+ ]
kmi0 = Pl050(pio_addr=0x1c060000, int_num=44, ps2=PS2Keyboard())
kmi1 = Pl050(pio_addr=0x1c070000, int_num=45, ps2=PS2TouchKit())
@@ -1163,7 +1165,7 @@
def _off_chip_devices(self):
return [
self.realview_io,
- self.uart0,
+ self.uart[0],
self.kmi0,
self.kmi1,
self.rtc,
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/12472
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I20b8dbac794d6a9be19b6ce8c335a097872132fb
Gerrit-Change-Number: 12472
Gerrit-PatchSet: 1
Gerrit-Owner: Ciro Santilli <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
