Gabe Black has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/14464 )
Change subject: hsail: Remove the MiscReg type.
......................................................................
hsail: Remove the MiscReg type.
It has been replaced by the ISA agnostic RegVal.
Change-Id: I563ea3852e37b5c1cf51eb0ac9a6f2a827ba89cf
Reviewed-on: https://gem5-review.googlesource.com/c/14464
Reviewed-by: Brandon Potter <[email protected]>
Maintainer: Gabe Black <[email protected]>
---
M src/arch/hsail/gpu_isa.hh
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Brandon Potter: Looks good to me, approved
Gabe Black: Looks good to me, approved
diff --git a/src/arch/hsail/gpu_isa.hh b/src/arch/hsail/gpu_isa.hh
index fa2cde3..86af905 100644
--- a/src/arch/hsail/gpu_isa.hh
+++ b/src/arch/hsail/gpu_isa.hh
@@ -45,8 +45,6 @@
namespace HsailISA
{
- typedef uint64_t MiscReg;
-
class GPUISA
{
public:
@@ -55,12 +53,12 @@
}
void
- writeMiscReg(int opIdx, MiscReg operandVal)
+ writeMiscReg(int opIdx, RegVal operandVal)
{
fatal("HSAIL does not implement misc registers yet\n");
}
- MiscReg
+ RegVal
readMiscReg(int opIdx) const
{
fatal("HSAIL does not implement misc registers yet\n");
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/14464
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I563ea3852e37b5c1cf51eb0ac9a6f2a827ba89cf
Gerrit-Change-Number: 14464
Gerrit-PatchSet: 7
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Brandon Potter <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
