Jason Lowe-Power has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/17453 )
Change subject: tests: Fix race condition in download fixture
......................................................................
tests: Fix race condition in download fixture
Change-Id: Idace0e9e71a484080fc581e232ce217b449085c1
Signed-off-by: Jason Lowe-Power <ja...@lowepower.com>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/17453
Reviewed-by: Andreas Sandberg <andreas.sandb...@arm.com>
---
M tests/gem5/fixture.py
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Andreas Sandberg: Looks good to me, approved
Jason Lowe-Power: Looks good to me, approved
diff --git a/tests/gem5/fixture.py b/tests/gem5/fixture.py
index 9d9319c..c4fd12f 100644
--- a/tests/gem5/fixture.py
+++ b/tests/gem5/fixture.py
@@ -229,9 +229,14 @@
self.url = self.urlbase + self.path
def _download(self):
import urllib
+ import errno
log.test_log.debug("Downloading " + self.url + " to " + self.path)
if not os.path.exists(self.program_dir):
- os.makedirs(self.program_dir)
+ try:
+ os.makedirs(self.program_dir)
+ except OSError as e:
+ if e.errno != errno.EEXIST:
+ raise
urllib.urlretrieve(self.url, self.path)
def _getremotetime(self):
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/17453
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Idace0e9e71a484080fc581e232ce217b449085c1
Gerrit-Change-Number: 17453
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-Reviewer: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-Reviewer: Anthony Gutierrez <anthony.gutier...@amd.com>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-Reviewer: Sean Wilson <spwils...@wisc.edu>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
