Sure, now worries, it's not on top of our priority list 🙂 Many thanks
Giacomo ________________________________ From: Gabe Black <gabebl...@google.com> Sent: 09 August 2019 00:35 To: Giacomo Travaglini <giacomo.travagl...@arm.com>; gem5 Developer List <gem5-dev@gem5.org> Subject: Re: Change in gem5/gem5[master]: sim: Add getter to fault virtual address Hi Giacomo, sorry I haven't gotten to this yet, it's on my todo list. If I don't get to it in a while, feel free to ping me about it. Gabe On Thu, Jul 18, 2019 at 8:09 AM Giacomo Travaglini (Gerrit) <noreply-gerritcodereview-h9ivfzm1qkbgd9nn-hm...@google.com<mailto:noreply-gerritcodereview-h9ivfzm1qkbgd9nn-hm...@google.com>> wrote: Giacomo Travaglini submitted this change. View Change<https://gem5-review.googlesource.com/c/public/gem5/+/19176> Approvals: Giacomo Travaglini: Looks good to me, approved; Looks good to me, approved kokoro: Regressions pass sim: Add getter to fault virtual address Change-Id: Ifd493aee9e78b0b4ddcc71e90f48679543acb861 Signed-off-by: Giacomo Gabrielli <giacomo.gabrie...@arm.com<mailto:giacomo.gabrie...@arm.com>> Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/19176 Reviewed-by: Giacomo Travaglini <giacomo.travagl...@arm.com<mailto:giacomo.travagl...@arm.com>> Maintainer: Giacomo Travaglini <giacomo.travagl...@arm.com<mailto:giacomo.travagl...@arm.com>> Tested-by: kokoro <noreply+kok...@google.com<mailto:noreply%2bkok...@google.com>> --- M src/sim/faults.hh 1 file changed, 2 insertions(+), 0 deletions(-) diff --git a/src/sim/faults.hh b/src/sim/faults.hh index 7475971..47855e7 100644 --- a/src/sim/faults.hh +++ b/src/sim/faults.hh @@ -99,6 +99,7 @@ GenericPageTableFault(Addr va) : vaddr(va) {} void invoke(ThreadContext * tc, const StaticInstPtr &inst = StaticInst::nullStaticInstPtr); + Addr getFaultVAddr() const { return vaddr; } }; class GenericAlignmentFault : public FaultBase @@ -110,6 +111,7 @@ GenericAlignmentFault(Addr va) : vaddr(va) {} void invoke(ThreadContext * tc, const StaticInstPtr &inst = StaticInst::nullStaticInstPtr); + Addr getFaultVAddr() const { return vaddr; } }; #endif // __FAULTS_HH__ To view, visit change 19176<https://gem5-review.googlesource.com/c/public/gem5/+/19176>. To unsubscribe, or for help writing mail filters, visit settings<https://gem5-review.googlesource.com/settings>. Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: Ifd493aee9e78b0b4ddcc71e90f48679543acb861 Gerrit-Change-Number: 19176 Gerrit-PatchSet: 4 Gerrit-Owner: Giacomo Gabrielli <giacomo.gabrie...@arm.com<mailto:giacomo.gabrie...@arm.com>> Gerrit-Reviewer: Gabe Black <gabebl...@google.com<mailto:gabebl...@google.com>> Gerrit-Reviewer: Gabor Dozsa <gabor.do...@arm.com<mailto:gabor.do...@arm.com>> Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com<mailto:giacomo.travagl...@arm.com>> Gerrit-Reviewer: Jason Lowe-Power <ja...@lowepower.com<mailto:ja...@lowepower.com>> Gerrit-Reviewer: kokoro <noreply+kok...@google.com<mailto:noreply%2bkok...@google.com>> Gerrit-CC: Juha Jäykkä <juha.jay...@arm.com<mailto:juha.jay...@arm.com>> Gerrit-MessageType: merged IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
