Timothy Hayes has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/21259 )
Change subject: ruby: 2x protocols has typo/syntax error that fails building
......................................................................
ruby: 2x protocols has typo/syntax error that fails building
MOESI_hammer and MOESI_CMP_token contain incorrect lines.
Change-Id: I1f9ac429d0f4dcb0241f21c8c9b831bee7aa37a4
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/21259
Reviewed-by: Jason Lowe-Power <ja...@lowepower.com>
Maintainer: Jason Lowe-Power <ja...@lowepower.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/mem/ruby/protocol/MOESI_CMP_token-L1cache.sm
M src/mem/ruby/protocol/MOESI_hammer-dir.sm
2 files changed, 0 insertions(+), 2 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/mem/ruby/protocol/MOESI_CMP_token-L1cache.sm
b/src/mem/ruby/protocol/MOESI_CMP_token-L1cache.sm
index 960afda..17c518a 100644
--- a/src/mem/ruby/protocol/MOESI_CMP_token-L1cache.sm
+++ b/src/mem/ruby/protocol/MOESI_CMP_token-L1cache.sm
@@ -695,7 +695,6 @@
in_msg.LineAddress, L1Icache_entry, tbe);
} else {
// No room in the L1, so we need to make room
- trigger(Event:L1_Replacement,
Addr victim := L1Icache.cacheProbe(in_msg.LineAddress);
trigger(Event:L1_Replacement,
victim, getL1ICacheEntry(victim), L1_TBEs[victim]);
diff --git a/src/mem/ruby/protocol/MOESI_hammer-dir.sm
b/src/mem/ruby/protocol/MOESI_hammer-dir.sm
index d85ff19..3b00168 100644
--- a/src/mem/ruby/protocol/MOESI_hammer-dir.sm
+++ b/src/mem/ruby/protocol/MOESI_hammer-dir.sm
@@ -426,7 +426,6 @@
trigger(cache_request_to_event(in_msg.Type), in_msg.addr,
pf_entry, tbe);
} else {
- trigger(Event:Pf_Replacement,
Addr victim := probeFilter.cacheProbe(in_msg.addr);
trigger(Event:Pf_Replacement,
victim, getProbeFilterEntry(victim), TBEs[victim]);
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/21259
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I1f9ac429d0f4dcb0241f21c8c9b831bee7aa37a4
Gerrit-Change-Number: 21259
Gerrit-PatchSet: 3
Gerrit-Owner: Timothy Hayes <timothy.ha...@arm.com>
Gerrit-Reviewer: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-Reviewer: JING QU <jq...@wisc.edu>
Gerrit-Reviewer: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-Reviewer: Timothy Hayes <timothy.ha...@arm.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-CC: Daniel Carvalho <oda...@yahoo.com.br>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
