Hello Andreas Sandberg, Steve Reinhardt, Giacomo Travaglini, Giacomo
Travaglini, Nikos Nikoleris,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/21679
to look at the new patch set (#2).
Change subject: tests: Added GTests for base/chunk_generator.hh
......................................................................
tests: Added GTests for base/chunk_generator.hh
Test "ChunkGeneratorTest.StartAtNonZero" revealed a bug in
ChunkGenerator's constructor which did not take into account the case
where the start address is non-zero. Previously "sizeLeft" was
miscalculated and led to an incorrect number of "next()" calls before
"done()" and "last()" equated to true.
Change-Id: Ic6ededfc7fed1f91a75e48a0933e61b4670e5af1
---
M src/base/SConscript
M src/base/chunk_generator.hh
A src/base/chunk_generator.test.cc
3 files changed, 217 insertions(+), 1 deletion(-)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/21679
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Ic6ededfc7fed1f91a75e48a0933e61b4670e5af1
Gerrit-Change-Number: 21679
Gerrit-PatchSet: 2
Gerrit-Owner: Bobby R. Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@gmail.com>
Gerrit-Reviewer: Nikos Nikoleris <nikos.nikole...@arm.com>
Gerrit-Reviewer: Steve Reinhardt <ste...@gmail.com>
Gerrit-MessageType: newpatchset
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
