Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/22100 )
Change subject: cpu: Stop checking for PC changes when servicing a
PCEventQueue.
......................................................................
cpu: Stop checking for PC changes when servicing a PCEventQueue.
First of all, this would arbitrarily skip events based on when they
were encountered in the queue. Second, this is one of the three places
where the ThreadContext is actually accessed in pc_event.cc. By
removing this and the other uses, this file can be included even when
using the NULL ISA, and a lot of #ifdefs can be removed.
Change-Id: If81f5e9ff9d3f9833145fec0b6062b4bda8d2e47
---
M src/cpu/pc_event.cc
1 file changed, 0 insertions(+), 7 deletions(-)
diff --git a/src/cpu/pc_event.cc b/src/cpu/pc_event.cc
index 65094f0..90c8733 100644
--- a/src/cpu/pc_event.cc
+++ b/src/cpu/pc_event.cc
@@ -92,13 +92,6 @@
int serviced = 0;
range_t range = equal_range(pc);
for (iterator i = range.first; i != range.second; ++i) {
- // Make sure that the pc wasn't changed as the side effect of
- // another event. This for example, prevents two invocations
- // of the SkipFuncEvent. Maybe we should have separate PC
- // event queues for each processor?
- if (pc != tc->instAddr())
- continue;
-
DPRINTF(PCEvent, "PC based event serviced at %#x: %s\n",
(*i)->pc(), (*i)->descr());
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/22100
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: If81f5e9ff9d3f9833145fec0b6062b4bda8d2e47
Gerrit-Change-Number: 22100
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <gabebl...@google.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
