Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/21782 )
Change subject: mips,riscv: Get rid of some Alpha cruft in these System
classes.
......................................................................
mips,riscv: Get rid of some Alpha cruft in these System classes.
The consolePanicEvent pointer and addConsoleFuncEvent template were
inherited from Alpha and were not used (and probably make no sense) for
MIPS or RISCV which (to my knowledge) don't have the idea of a
"console" binary.
Change-Id: I109b866a65f69c7334062f7304c7b18acc51d99d
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/21782
Tested-by: kokoro <[email protected]>
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
---
M src/arch/mips/system.hh
M src/arch/riscv/system.hh
2 files changed, 0 insertions(+), 26 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/mips/system.hh b/src/arch/mips/system.hh
index eb28b3b..c48faa1 100644
--- a/src/arch/mips/system.hh
+++ b/src/arch/mips/system.hh
@@ -66,22 +66,9 @@
/** Object pointer for the console code */
ObjectFile *console;
-#ifndef NDEBUG
- /** Event to halt the simulator if the console calls panic() */
- BreakPCEvent *consolePanicEvent;
-#endif
-
protected:
const Params *params() const { return (const Params *)_params; }
- /** Add a function-based event to the console code. */
- template <class T>
- T *
- addConsoleFuncEvent(const char *lbl)
- {
- return addFuncEvent<T>(consoleSymtab, lbl);
- }
-
virtual Addr fixFuncEventAddr(Addr addr);
};
diff --git a/src/arch/riscv/system.hh b/src/arch/riscv/system.hh
index 7bff5cd..78638d0 100644
--- a/src/arch/riscv/system.hh
+++ b/src/arch/riscv/system.hh
@@ -79,22 +79,9 @@
/** Object pointer for the console code */
ObjectFile *console;
-#ifndef NDEBUG
- /** Event to halt the simulator if the console calls panic() */
- BreakPCEvent *consolePanicEvent;
-#endif
-
protected:
const Params *params() const { return (const Params *)_params; }
- /** Add a function-based event to the console code. */
- template <class T>
- T *
- addConsoleFuncEvent(const char *lbl)
- {
- return addFuncEvent<T>(consoleSymtab, lbl);
- }
-
virtual Addr fixFuncEventAddr(Addr addr);
};
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/21782
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I109b866a65f69c7334062f7304c7b18acc51d99d
Gerrit-Change-Number: 21782
Gerrit-PatchSet: 3
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Alec Roelke <[email protected]>
Gerrit-Reviewer: Brandon Potter <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
