Andrea Mondelli has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/23380 )
Change subject: arch-x86: missing override specifier
......................................................................
arch-x86: missing override specifier
Change-Id: I5a6db4632ec5b670cbfeb7d52190a7545c0b985f
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/23380
Reviewed-by: Gabe Black <gabebl...@google.com>
Maintainer: Gabe Black <gabebl...@google.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/arch/x86/interrupts.hh
1 file changed, 7 insertions(+), 7 deletions(-)
Approvals:
Gabe Black: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/x86/interrupts.hh b/src/arch/x86/interrupts.hh
index 3c383ab..5a07dad 100644
--- a/src/arch/x86/interrupts.hh
+++ b/src/arch/x86/interrupts.hh
@@ -196,7 +196,7 @@
*/
typedef X86LocalApicParams Params;
- void setCPU(BaseCPU * newCPU);
+ void setCPU(BaseCPU * newCPU) override;
const Params *
params() const
@@ -264,7 +264,7 @@
* Functions for retrieving interrupts for the CPU to handle.
*/
- bool checkInterrupts(ThreadContext *tc) const;
+ bool checkInterrupts(ThreadContext *tc) const override;
/**
* Check if there are pending interrupts without ignoring the
* interrupts disabled flag.
@@ -278,8 +278,8 @@
* @return true there are unmaskable interrupts pending.
*/
bool hasPendingUnmaskable() const { return pendingUnmaskableInt; }
- Fault getInterrupt(ThreadContext *tc);
- void updateIntrInfo(ThreadContext *tc);
+ Fault getInterrupt(ThreadContext *tc) override;
+ void updateIntrInfo(ThreadContext *tc) override;
/*
* Serialization.
@@ -292,19 +292,19 @@
* eventually.
*/
void
- post(int int_num, int index)
+ post(int int_num, int index) override
{
panic("Interrupts::post unimplemented!\n");
}
void
- clear(int int_num, int index)
+ clear(int int_num, int index) override
{
panic("Interrupts::clear unimplemented!\n");
}
void
- clearAll()
+ clearAll() override
{
panic("Interrupts::clearAll unimplemented!\n");
}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/23380
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I5a6db4632ec5b670cbfeb7d52190a7545c0b985f
Gerrit-Change-Number: 23380
Gerrit-PatchSet: 3
Gerrit-Owner: Andrea Mondelli <andrea.monde...@ucf.edu>
Gerrit-Reviewer: Andrea Mondelli <andrea.monde...@ucf.edu>
Gerrit-Reviewer: Gabe Black <gabebl...@google.com>
Gerrit-Reviewer: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
