Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/23402 )
Change subject: kvm,arm: Update the KVM ARM v8 CPU to use vector regs.
......................................................................
kvm,arm: Update the KVM ARM v8 CPU to use vector regs.
The exact mapping of the KVM registers and the gem5 registers is direct and
may not actually be correct.
Change-Id: Idb0981105c002e65755f8dfc315dbb95ea9370df
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/23402
Reviewed-by: Giacomo Travaglini <giacomo.travagl...@arm.com>
Maintainer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/arch/arm/kvm/armv8_cpu.cc
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Giacomo Travaglini: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/arm/kvm/armv8_cpu.cc b/src/arch/arm/kvm/armv8_cpu.cc
index 5a843fc..2ac9744 100644
--- a/src/arch/arm/kvm/armv8_cpu.cc
+++ b/src/arch/arm/kvm/armv8_cpu.cc
@@ -249,10 +249,10 @@
}
for (int i = 0; i < NUM_QREGS; ++i) {
- const RegIndex reg_base(i * FP_REGS_PER_VFP_REG);
KvmFPReg reg;
+ auto v = tc->readVecReg(RegId(VecRegClass, i)).as<VecElem>();
for (int j = 0; j < FP_REGS_PER_VFP_REG; j++)
- reg.s[j].i = tc->readFloatReg(reg_base + j);
+ reg.s[j].i = v[j];
setOneReg(kvmFPReg(i), reg.data);
DPRINTF(KvmContext, " Q%i: %s\n", i,
getAndFormatOneReg(kvmFPReg(i)));
@@ -321,12 +321,12 @@
}
for (int i = 0; i < NUM_QREGS; ++i) {
- const RegIndex reg_base(i * FP_REGS_PER_VFP_REG);
KvmFPReg reg;
DPRINTF(KvmContext, " Q%i: %s\n", i,
getAndFormatOneReg(kvmFPReg(i)));
getOneReg(kvmFPReg(i), reg.data);
+ auto v = tc->getWritableVecReg(RegId(VecRegClass,
i)).as<VecElem>();
for (int j = 0; j < FP_REGS_PER_VFP_REG; j++)
- tc->setFloatReg(reg_base + j, reg.s[j].i);
+ v[j] = reg.s[j].i;
}
for (const auto &ri : getSysRegMap()) {
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/23402
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Idb0981105c002e65755f8dfc315dbb95ea9370df
Gerrit-Change-Number: 23402
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black <gabebl...@google.com>
Gerrit-Reviewer: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-Reviewer: Ciro Santilli <ciro.santi...@arm.com>
Gerrit-Reviewer: Gabe Black <gabebl...@google.com>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
