Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/24389 )
Change subject: arm: Remove checkpointing from the ARM TLBs.
......................................................................
arm: Remove checkpointing from the ARM TLBs.
All of the state being checkpointed would either be provided by the
config directly, or would be brought into the TLB through normal fill
operations. Having this state in the checkpoint complicates the
checkpoint and significantly decreases compatibility with other TLB
implementations, or even variations of the same TLB, for instance if
the size was changed.
Change-Id: I4ea079dd01ff18fbc458b3aaaf88519dbcfdd869
---
M src/arch/arm/tlb.cc
M src/arch/arm/tlb.hh
2 files changed, 0 insertions(+), 38 deletions(-)
diff --git a/src/arch/arm/tlb.cc b/src/arch/arm/tlb.cc
index 1e4904c..af0f862 100644
--- a/src/arch/arm/tlb.cc
+++ b/src/arch/arm/tlb.cc
@@ -405,40 +405,6 @@
}
void
-TLB::serialize(CheckpointOut &cp) const
-{
- DPRINTF(Checkpoint, "Serializing Arm TLB\n");
-
- SERIALIZE_SCALAR(_attr);
- SERIALIZE_SCALAR(haveLPAE);
- SERIALIZE_SCALAR(directToStage2);
- SERIALIZE_SCALAR(stage2Req);
- SERIALIZE_SCALAR(stage2DescReq);
-
- int num_entries = size;
- SERIALIZE_SCALAR(num_entries);
- for (int i = 0; i < size; i++)
- table[i].serializeSection(cp, csprintf("TlbEntry%d", i));
-}
-
-void
-TLB::unserialize(CheckpointIn &cp)
-{
- DPRINTF(Checkpoint, "Unserializing Arm TLB\n");
-
- UNSERIALIZE_SCALAR(_attr);
- UNSERIALIZE_SCALAR(haveLPAE);
- UNSERIALIZE_SCALAR(directToStage2);
- UNSERIALIZE_SCALAR(stage2Req);
- UNSERIALIZE_SCALAR(stage2DescReq);
-
- int num_entries;
- UNSERIALIZE_SCALAR(num_entries);
- for (int i = 0; i < min(size, num_entries); i++)
- table[i].unserializeSection(cp, csprintf("TlbEntry%d", i));
-}
-
-void
TLB::regStats()
{
BaseTLB::regStats();
diff --git a/src/arch/arm/tlb.hh b/src/arch/arm/tlb.hh
index ea78a21..6314ef2 100644
--- a/src/arch/arm/tlb.hh
+++ b/src/arch/arm/tlb.hh
@@ -383,10 +383,6 @@
void drainResume() override;
- // Checkpointing
- void serialize(CheckpointOut &cp) const override;
- void unserialize(CheckpointIn &cp) override;
-
void regStats() override;
void regProbePoints() override;
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/24389
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I4ea079dd01ff18fbc458b3aaaf88519dbcfdd869
Gerrit-Change-Number: 24389
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <gabebl...@google.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
