Hello Nikos Nikoleris,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/27086
to review the following change.
Change subject: dev-arm: Don't use args and kwargs on attachIO
......................................................................
dev-arm: Don't use args and kwargs on attachIO
This is matching the attachOnChipIO style, and fixing the error of the
dma_ports kwarg being forwarded to the _attach_mem
Change-Id: Ib3ecf2fc18c488d938bbbf63eab3d7693cdb7d06
Signed-off-by: Giacomo Travaglini <giacomo.travagl...@arm.com>
Reviewed-by: Nikos Nikoleris <nikos.nikole...@arm.com>
---
M src/dev/arm/RealView.py
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/dev/arm/RealView.py b/src/dev/arm/RealView.py
index f9b9cb2..43d2b15 100644
--- a/src/dev/arm/RealView.py
+++ b/src/dev/arm/RealView.py
@@ -625,9 +625,9 @@
if bridge:
bridge.ranges = self._off_chip_ranges
- def attachIO(self, *args, **kwargs):
- self._attach_mem(self._off_chip_memory(), *args, **kwargs)
- self._attach_io(self._off_chip_devices(), *args, **kwargs)
+ def attachIO(self, bus, dma_ports=None, mem_ports=None):
+ self._attach_mem(self._off_chip_memory(), bus, mem_ports)
+ self._attach_io(self._off_chip_devices(), bus, dma_ports)
def setupBootLoader(self, cur_sys, boot_loader, atags_addr,
load_offset):
cur_sys.workload.boot_loader = boot_loader
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/27086
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ib3ecf2fc18c488d938bbbf63eab3d7693cdb7d06
Gerrit-Change-Number: 27086
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Nikos Nikoleris <nikos.nikole...@arm.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
