Yes, I also want to say thank you to everybody for getting through a lot of reviews. We do still want to be careful since while our testing has come a long way, we still have a better chance of catching bugs as they come in than once they're floating around our big codebase somewhere. But still, it's been very nice to get some many CLs taken care of!
Gabe On Tue, Apr 28, 2020 at 9:05 AM Jason Lowe-Power via gem5-dev < gem5-dev@gem5.org> wrote: > Hey Gabe, > > While I agree that we need to have as many eyes on changesets as possible, > not having enough reviews is not a new phenomenon. IIRC, this has happened > with a number of your commits as well ;). It's just going to happen > sometimes :). > > Actually, I want to thank everyone that's working so hard to get through > our backlog of gerrit changes! This flurry of reviews and commits is super > exciting! > > Remember, we'll have a two week time period for deep testing on the > "staging" branch before we make the final release. The purpose of this time > period is to catch all of the remaining bugs that we can. > > Cheers, > Jason > > On Mon, Apr 27, 2020 at 12:10 PM Gabe Black via gem5-dev < > gem5-dev@gem5.org> > wrote: > > > Hey everybody, lets slow down here a little so that I have a chance to > > actually see a review before the change gets checked in. I think we have > at > > least one bug checked in already. If a change hangs around for months > > that's too long, but at least a day so everyone has a chance to see > what's > > going is a reasonable minimum. > > > > Gabe > > _______________________________________________ > > gem5-dev mailing list -- gem5-dev@gem5.org > > To unsubscribe send an email to gem5-dev-le...@gem5.org > > %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s > > > _______________________________________________ > gem5-dev mailing list -- gem5-dev@gem5.org > To unsubscribe send an email to gem5-dev-le...@gem5.org > %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s > _______________________________________________ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
