Hello Tony Gutierrez, Xianwei Zhang,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/29924
to review the following change.
Change subject: arch-gcn3: Implement instruction v_div_fixup_f32
......................................................................
arch-gcn3: Implement instruction v_div_fixup_f32
Instruction v_div_fixup_f32 was unimplemented. The
implementation was added by mimicking v_div_fixup_f64.
Change-Id: I9306b198f327e9fde3414aa1bb2bec20503b1efd
---
M src/arch/gcn3/insts/instructions.cc
1 file changed, 59 insertions(+), 3 deletions(-)
diff --git a/src/arch/gcn3/insts/instructions.cc
b/src/arch/gcn3/insts/instructions.cc
index 308fd5d..26af241 100644
--- a/src/arch/gcn3/insts/instructions.cc
+++ b/src/arch/gcn3/insts/instructions.cc
@@ -28671,9 +28671,65 @@
void
Inst_VOP3__V_DIV_FIXUP_F32::execute(GPUDynInstPtr gpuDynInst)
{
- // Could not parse sq_uc.arch desc field
- panicUnimplemented();
- }
+ Wavefront *wf = gpuDynInst->wavefront();
+ ConstVecOperandF32 src0(gpuDynInst, extData.SRC0);
+ ConstVecOperandF32 src1(gpuDynInst, extData.SRC1);
+ ConstVecOperandF32 src2(gpuDynInst, extData.SRC2);
+ VecOperandF32 vdst(gpuDynInst, instData.VDST);
+
+ src0.readSrc();
+ src1.readSrc();
+ src2.readSrc();
+
+ if (instData.ABS & 0x1) {
+ src0.absModifier();
+ }
+
+ if (instData.ABS & 0x2) {
+ src1.absModifier();
+ }
+
+ if (instData.ABS & 0x4) {
+ src2.absModifier();
+ }
+
+ if (extData.NEG & 0x1) {
+ src0.negModifier();
+ }
+
+ if (extData.NEG & 0x2) {
+ src1.negModifier();
+ }
+
+ if (extData.NEG & 0x4) {
+ src2.negModifier();
+ }
+
+ for (int lane = 0; lane < NumVecElemPerVecReg; ++lane) {
+ if (wf->execMask(lane)) {
+ if (std::fpclassify(src1[lane]) == FP_ZERO) {
+ if (std::signbit(src1[lane])) {
+ vdst[lane] = -INFINITY;
+ } else {
+ vdst[lane] = +INFINITY;
+ }
+ } else if (std::isnan(src2[lane]) ||
std::isnan(src1[lane])) {
+ vdst[lane] = NAN;
+ } else if (std::isinf(src1[lane])) {
+ if (std::signbit(src1[lane])) {
+ vdst[lane] = -INFINITY;
+ } else {
+ vdst[lane] = +INFINITY;
+ }
+ } else {
+ vdst[lane] = src2[lane] / src1[lane];
+ }
+ }
+ }
+
+ vdst.write();
+ } // execute
+ // --- Inst_VOP3__V_DIV_FIXUP_F64 class methods ---
Inst_VOP3__V_DIV_FIXUP_F64::Inst_VOP3__V_DIV_FIXUP_F64(InFmt_VOP3
*iFmt)
: Inst_VOP3(iFmt, "v_div_fixup_f64", false)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/29924
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I9306b198f327e9fde3414aa1bb2bec20503b1efd
Gerrit-Change-Number: 29924
Gerrit-PatchSet: 1
Gerrit-Owner: Anthony Gutierrez <anthony.gutier...@amd.com>
Gerrit-Reviewer: Tony Gutierrez <anthony.gutier...@amd.com>
Gerrit-Reviewer: Xianwei Zhang <xianwei.zh...@amd.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
