Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/32116 )
Change subject: scons: Remove explicitly set defaults in calls to AddOption.
......................................................................
scons: Remove explicitly set defaults in calls to AddOption.
Like the optparse module's add_option method, most keyword arguments
have sensible default values. We should avoid setting those explicitly
when calling AddOption, since it usually doesn't make anything clearer
and just adds more text to wade through.
Change-Id: I70e425d9f1a0da1cafcc3d7dd24bfde18c0b3f35
---
M SConstruct
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/SConstruct b/SConstruct
index 400af5b..77192d6 100755
--- a/SConstruct
+++ b/SConstruct
@@ -104,33 +104,32 @@
help="Add color to abbreviated scons output")
AddOption('--no-colors', dest='use_colors', action='store_false',
help="Don't add color to abbreviated scons output")
-AddOption('--with-cxx-config', dest='with_cxx_config', action='store_true',
+AddOption('--with-cxx-config', action='store_true',
help="Build with support for C++-based configuration")
-AddOption('--default', dest='default', type='string', action='store',
+AddOption('--default',
help='Override which build_opts file to use for defaults')
-AddOption('--ignore-style', dest='ignore_style', action='store_true',
+AddOption('--ignore-style', action='store_true',
help='Disable style checking hooks')
-AddOption('--gold-linker', dest='gold_linker', action='store_true',
- help='Use the gold linker')
-AddOption('--no-lto', dest='no_lto', action='store_true',
+AddOption('--gold-linker', action='store_true', help='Use the gold linker')
+AddOption('--no-lto', action='store_true',
help='Disable Link-Time Optimization for fast')
-AddOption('--force-lto', dest='force_lto', action='store_true',
+AddOption('--force-lto', action='store_true',
help='Use Link-Time Optimization instead of partial linking' +
' when the compiler doesn\'t support using them together.')
-AddOption('--update-ref', dest='update_ref', action='store_true',
+AddOption('--update-ref', action='store_true',
help='Update test reference outputs')
-AddOption('--verbose', dest='verbose', action='store_true',
+AddOption('--verbose', action='store_true',
help='Print full tool command lines')
-AddOption('--without-python', dest='without_python', action='store_true',
+AddOption('--without-python', action='store_true',
help='Build without Python configuration support')
-AddOption('--without-tcmalloc', dest='without_tcmalloc',
action='store_true',
+AddOption('--without-tcmalloc', action='store_true',
help='Disable linking against tcmalloc')
-AddOption('--with-ubsan', dest='with_ubsan', action='store_true',
+AddOption('--with-ubsan', action='store_true',
help='Build with Undefined Behavior Sanitizer if available')
-AddOption('--with-asan', dest='with_asan', action='store_true',
+AddOption('--with-asan', action='store_true',
help='Build with Address Sanitizer if available')
-AddOption('--with-systemc-tests', dest='with_systemc_tests',
- action='store_true', help='Build systemc tests')
+AddOption('--with-systemc-tests', action='store_true',
+ help='Build systemc tests')
from gem5_scons import Transform, error, warning, summarize_warnings
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/32116
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I70e425d9f1a0da1cafcc3d7dd24bfde18c0b3f35
Gerrit-Change-Number: 32116
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <gabebl...@google.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
