Hello Onur Kayıran,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/32276
to review the following change.
Change subject: mem-garnet: Fix topology initialization bug
......................................................................
mem-garnet: Fix topology initialization bug
This change fixes an issue when links are iterated during topology
initialization. The bug falsely can cause an assert statement to be
true when multiple physical links between the same
source-destination pair are used.
Change-Id: Idd3fcd1ade7bab6d24391cc20f79643167be087a
---
M src/mem/ruby/network/Topology.cc
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mem/ruby/network/Topology.cc
b/src/mem/ruby/network/Topology.cc
index 1c8497f..e1622d8 100644
--- a/src/mem/ruby/network/Topology.cc
+++ b/src/mem/ruby/network/Topology.cc
@@ -167,7 +167,7 @@
int vnet = link->mVnets[v];
// Two links connecting same src and destination
// cannot carry same vnets.
- fatal_if(vnet_done[v], "Two links connecting same src"
+ fatal_if(vnet_done[vnet], "Two links connecting same
src"
" and destination cannot support same vnets");
component_latencies[src][dst][vnet] = link->m_latency;
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/32276
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: feature-heterogarnet
Gerrit-Change-Id: Idd3fcd1ade7bab6d24391cc20f79643167be087a
Gerrit-Change-Number: 32276
Gerrit-PatchSet: 1
Gerrit-Owner: Srikant Bharadwaj <srikant.bharad...@amd.com>
Gerrit-Reviewer: Onur Kayıran <onur.kayi...@amd.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
