Hello Emily Brickey,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/32309
to review the following change.
Change subject: misc: Updated port classes & refs to remove
slaveBind()/UnBind()
......................................................................
misc: Updated port classes & refs to remove slaveBind()/UnBind()
Change-Id: I9106397b8816d8148dd916510bbcf65ed499d303
---
M src/mem/port.cc
M src/mem/port.hh
M src/mem/token_port.cc
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/mem/port.cc b/src/mem/port.cc
index 6460b59..b901571 100644
--- a/src/mem/port.cc
+++ b/src/mem/port.cc
@@ -131,7 +131,7 @@
_responsePort = response_port;
Port::bind(peer);
// response port also keeps track of request port
- _responsePort->slaveBind(*this);
+ _responsePort->responderBind(*this);
}
void
@@ -139,7 +139,7 @@
{
panic_if(!isConnected(), "Can't unbind request port %s which is "
"not bound.", name());
- _responsePort->slaveUnbind();
+ _responsePort->responderUnbind();
_responsePort = &defaultResponsePort;
Port::unbind();
}
@@ -164,7 +164,7 @@
}
/**
- * Slave port
+ * Response port
*/
ResponsePort::ResponsePort(const std::string& name, SimObject* _owner,
PortID id) : Port(name, id), _requestPort(&defaultRequestPort),
@@ -177,14 +177,14 @@
}
void
-ResponsePort::slaveUnbind()
+ResponsePort::responderUnbind()
{
_requestPort = &defaultRequestPort;
Port::unbind();
}
void
-ResponsePort::slaveBind(RequestPort& request_port)
+ResponsePort::responderBind(RequestPort& request_port)
{
_requestPort = &request_port;
Port::bind(request_port);
diff --git a/src/mem/port.hh b/src/mem/port.hh
index 16ca5d7..17f8596 100644
--- a/src/mem/port.hh
+++ b/src/mem/port.hh
@@ -422,13 +422,13 @@
* Called by the requestor port to unbind. Should never be called
* directly.
*/
- void slaveUnbind();
+ void responderUnbind();
/**
* Called by the requestor port to bind. Should never be called
* directly.
*/
- void slaveBind(RequestPort& request_port);
+ void responderBind(RequestPort& request_port);
/**
* Default implementations.
diff --git a/src/mem/token_port.cc b/src/mem/token_port.cc
index 1a8439d..46d9116 100644
--- a/src/mem/token_port.cc
+++ b/src/mem/token_port.cc
@@ -109,7 +109,7 @@
void
TokenSlavePort::unbind()
{
- SlavePort::slaveUnbind();
+ SlavePort::responderUnbind();
tokenMasterPort = nullptr;
}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/32309
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I9106397b8816d8148dd916510bbcf65ed499d303
Gerrit-Change-Number: 32309
Gerrit-PatchSet: 1
Gerrit-Owner: Shivani Parekh <shpar...@ucdavis.edu>
Gerrit-Reviewer: Emily Brickey <esbric...@ucdavis.edu>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
