[gem5-dev] Change in gem5/gem5[develop]: mem: convert base to new style stats

[Eden Avivi (Gerrit) via gem5-dev]

Eden Avivi has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/33474 )

Change subject: mem: convert base to new style stats
......................................................................

mem: convert base to new style stats

Base inside src/mem/cache/prefetch converted

Change-Id: I5b51fcdce43309bb588599325f10366968dca82d
---
M src/mem/cache/prefetch/base.cc
M src/mem/cache/prefetch/base.hh
2 files changed, 12 insertions(+), 19 deletions(-)



diff --git a/src/mem/cache/prefetch/base.cc b/src/mem/cache/prefetch/base.cc
index d4223aa..87d5d54 100644
--- a/src/mem/cache/prefetch/base.cc
+++ b/src/mem/cache/prefetch/base.cc
@@ -94,7 +94,8 @@
       onWrite(p->on_write), onData(p->on_data), onInst(p->on_inst),
       masterId(p->sys->getMasterId(this)),  
pageBytes(p->sys->getPageBytes()),
       prefetchOnAccess(p->prefetch_on_access),
-      useVirtualAddresses(p->use_virtual_addresses), issuedPrefetches(0),
+      useVirtualAddresses(p->use_virtual_addresses),
+      stats_pbase(this), issuedPrefetches(0),
       usefulPrefetches(0), tlb(nullptr)
 {
 }
@@ -109,18 +110,12 @@
     blkSize = cache->getBlockSize();
     lBlkSize = floorLog2(blkSize);
 }
+Base::StatGroup::StatGroup(Stats::Group *parent)
+    : Stats::Group(parent),
+    ADD_STAT(pfIssued, "number of hwpf issued")
+    {
+    }

-void
-Base::regStats()
-{
-    ClockedObject::regStats();
-
-    pfIssued
-        .name(name() + ".num_hwpf_issued")
-        .desc("number of hwpf issued")
-        ;
-
-}

 bool
 Base::observeAccess(const PacketPtr &pkt, bool miss) const
diff --git a/src/mem/cache/prefetch/base.hh b/src/mem/cache/prefetch/base.hh
index 7009db7..a9e13e4 100644
--- a/src/mem/cache/prefetch/base.hh
+++ b/src/mem/cache/prefetch/base.hh
@@ -48,8 +48,8 @@

 #include <cstdint>

-#include "arch/isa_traits.hh"
 #include "arch/generic/tlb.hh"
+#include "arch/isa_traits.hh"
 #include "base/statistics.hh"
 #include "base/types.hh"
 #include "mem/packet.hh"
@@ -318,8 +318,10 @@
     Addr pageOffset(Addr a) const;
     /** Build the address of the i-th block inside the page */
     Addr pageIthBlockAddress(Addr page, uint32_t i) const;
-
-    Stats::Scalar pfIssued;
+    struct StatGroup : public Stats::Group {
+            StatGroup(Stats::Group *parent);
+            Stats::Scalar pfIssued;
+    } stats_pbase;

     /** Total prefetches issued */
     uint64_t issuedPrefetches;
@@ -349,10 +351,6 @@

     virtual Tick nextPrefetchReadyTime() const = 0;

-    /**
-     * Register local statistics.
-     */
-    void regStats() override;

     /**
      * Register probe points for this object.

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/33474
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I5b51fcdce43309bb588599325f10366968dca82d
Gerrit-Change-Number: 33474
Gerrit-PatchSet: 1
Gerrit-Owner: Eden Avivi <eav...@ucdavis.edu>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s