Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/34173 )
Change subject: gpu: Stop using TheISA in the GPU TLB.
......................................................................
gpu: Stop using TheISA in the GPU TLB.
This class is defined inside the X86ISA namespace, so there's no point
in pretending it's generic. Remove TheISA and let the code access what
it needs from X86ISA naturally since it's there already.
Change-Id: I21b5d2d2b9af6aa0c10ddbb5b3ddca1692188dcc
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/34173
Tested-by: kokoro <noreply+kok...@google.com>
Reviewed-by: Matthew Poremba <matthew.pore...@amd.com>
Reviewed-by: Matt Sinclair <mattdsincl...@gmail.com>
Maintainer: Matt Sinclair <mattdsincl...@gmail.com>
---
M src/gpu-compute/gpu_tlb.cc
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Matthew Poremba: Looks good to me, approved
Matt Sinclair: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/gpu-compute/gpu_tlb.cc b/src/gpu-compute/gpu_tlb.cc
index 4c35396..54c3729 100644
--- a/src/gpu-compute/gpu_tlb.cc
+++ b/src/gpu-compute/gpu_tlb.cc
@@ -164,7 +164,7 @@
* vpn holds the virtual page address
* The least significant bits are simply masked
*/
- int set = (vpn >> TheISA::PageShift) & setMask;
+ int set = (vpn >> PageShift) & setMask;
if (!freeList[set].empty()) {
newEntry = freeList[set].front();
@@ -184,7 +184,7 @@
GpuTLB::EntryList::iterator
GpuTLB::lookupIt(Addr va, bool update_lru)
{
- int set = (va >> TheISA::PageShift) & setMask;
+ int set = (va >> PageShift) & setMask;
if (FA) {
assert(!set);
@@ -214,7 +214,7 @@
TlbEntry*
GpuTLB::lookup(Addr va, bool update_lru)
{
- int set = (va >> TheISA::PageShift) & setMask;
+ int set = (va >> PageShift) & setMask;
auto entry = lookupIt(va, update_lru);
@@ -266,7 +266,7 @@
GpuTLB::demapPage(Addr va, uint64_t asn)
{
- int set = (va >> TheISA::PageShift) & setMask;
+ int set = (va >> PageShift) & setMask;
auto entry = lookupIt(va, false);
if (entry != entryList[set].end()) {
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/34173
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I21b5d2d2b9af6aa0c10ddbb5b3ddca1692188dcc
Gerrit-Change-Number: 34173
Gerrit-PatchSet: 3
Gerrit-Owner: Gabe Black <gabebl...@google.com>
Gerrit-Reviewer: Anthony Gutierrez <anthony.gutier...@amd.com>
Gerrit-Reviewer: Gabe Black <gabebl...@google.com>
Gerrit-Reviewer: Matt Sinclair <mattdsincl...@gmail.com>
Gerrit-Reviewer: Matthew Poremba <matthew.pore...@amd.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
