Bobby R. Bruce has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/37355 )
Change subject: dev-arm,misc: Added missing override to scmi_platform
functions
......................................................................
dev-arm,misc: Added missing override to scmi_platform functions
The missing overrides on the "raiseInterrupt" and "clearInterrupt"
resulted in compilation failures when using Clang.
Change-Id: Ic77e8587cd622f8f0cb819c3230893a1b169a2a2
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/37355
Reviewed-by: Jason Lowe-Power <[email protected]>
Reviewed-by: Giacomo Travaglini <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/dev/arm/css/scmi_platform.hh
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, but someone else must approve; Looks
good to me, approved
Giacomo Travaglini: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/dev/arm/css/scmi_platform.hh
b/src/dev/arm/css/scmi_platform.hh
index b46cfb0..567e548 100644
--- a/src/dev/arm/css/scmi_platform.hh
+++ b/src/dev/arm/css/scmi_platform.hh
@@ -292,8 +292,8 @@
Port& getPort(const std::string &if_name, PortID idx) override;
- void raiseInterrupt(const Doorbell *doorbell);
- void clearInterrupt(const Doorbell *doorbell);
+ void raiseInterrupt(const Doorbell *doorbell) override;
+ void clearInterrupt(const Doorbell *doorbell) override;
static uint32_t
protocolID(const Message &msg)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/37355
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ic77e8587cd622f8f0cb819c3230893a1b169a2a2
Gerrit-Change-Number: 37355
Gerrit-PatchSet: 2
Gerrit-Owner: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
