Hello all,
I've uploaded a commit that re-joins the debug header files into a single one: 
https://gem5-review.googlesource.com/c/public/gem5/+/39255. This means that 
instead of having to include a different header for each and every debug flag 
used in a file, only one is needed. For example, in src/arch/arm/kvm/arm_cpu.cc
| 
    #include "debug/Kvm.hh" |


|     #include "debug/KvmContext.hh" |

    #include "debug/KvmInt.hh"
would be replaced by
    #include "debug/flags.hh"
Finally, since most of the code using these flags will use DPRINTF or a similar 
macro, this include could be added to base/trace.hh, so that most of the times 
it would be included transitively.

The advantage of this change is that debugging becomes easier/faster: this file 
would behave as a library of supported flags and very few header files would 
suffice for all debugging needs. The disadvantage is that every time a commit 
introduces or removes a debug flag debug/flags.hh will be recompiled, which 
will cause an almost complete build. Luckily, debug flags are not frequently 
modified.

Performance-wise both approaches are similar.
What are your opinions in this matter?
Cheers,Daniel
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to