Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/39319 )
Change subject: sim: Eliminate the generic PseudoInstABI.
......................................................................
sim: Eliminate the generic PseudoInstABI.
Calls to gem5 ops are now handled by locally defined ABIs in each of the
ISAs that support them.
Change-Id: I30aac7b49fa8dc8e18aa7724338d1fd2adacda90
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/39319
Reviewed-by: Jason Lowe-Power <power...@gmail.com>
Maintainer: Gabe Black <gabe.bl...@gmail.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/sim/pseudo_inst.hh
1 file changed, 3 insertions(+), 24 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/sim/pseudo_inst.hh b/src/sim/pseudo_inst.hh
index d244adb..b0b65c6 100644
--- a/src/sim/pseudo_inst.hh
+++ b/src/sim/pseudo_inst.hh
@@ -45,35 +45,14 @@
class ThreadContext;
-#include "arch/utility.hh"
#include "base/bitfield.hh"
+#include "base/logging.hh"
+#include "base/trace.hh"
#include "base/types.hh" // For Tick and Addr data types.
+#include "cpu/thread_context.hh"
#include "debug/PseudoInst.hh"
#include "sim/guest_abi.hh"
-struct PseudoInstABI
-{
- using State = int;
-};
-
-namespace GuestABI
-{
-
-template <>
-struct Argument<PseudoInstABI, uint64_t>
-{
- static uint64_t
- get(ThreadContext *tc, PseudoInstABI::State &state)
- {
- uint64_t result =
- TheISA::getArgument(tc, state, sizeof(uint64_t), false);
- state++;
- return result;
- }
-};
-
-} // namespace GuestABI
-
namespace PseudoInst
{
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/39319
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I30aac7b49fa8dc8e18aa7724338d1fd2adacda90
Gerrit-Change-Number: 39319
Gerrit-PatchSet: 5
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Daniel Carvalho <oda...@yahoo.com.br>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-Reviewer: Jason Lowe-Power <power...@gmail.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
