Hoa Nguyen has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/40695 )
Change subject: arch-riscv: Fixed the style of stats variable names in
TlbStats
......................................................................
arch-riscv: Fixed the style of stats variable names in TlbStats
The variable names should be of camel case style.
Change-Id: I397c9f165a53ecc120ec57f7214c90a65e12407e
Signed-off-by: Hoa Nguyen <hoangu...@ucdavis.edu>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/40695
Tested-by: kokoro <noreply+kok...@google.com>
Reviewed-by: Bobby R. Bruce <bbr...@ucdavis.edu>
Reviewed-by: Daniel Carvalho <oda...@yahoo.com.br>
Maintainer: Bobby R. Bruce <bbr...@ucdavis.edu>
---
M src/arch/riscv/tlb.cc
M src/arch/riscv/tlb.hh
2 files changed, 21 insertions(+), 21 deletions(-)
Approvals:
Daniel Carvalho: Looks good to me, approved
Bobby R. Bruce: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/riscv/tlb.cc b/src/arch/riscv/tlb.cc
index 84eb6e2..8001d83 100644
--- a/src/arch/riscv/tlb.cc
+++ b/src/arch/riscv/tlb.cc
@@ -108,21 +108,21 @@
entry->lruSeq = nextSeq();
if (mode == Write)
- stats.write_accesses++;
+ stats.writeAccesses++;
else
- stats.read_accesses++;
+ stats.readAccesses++;
if (!entry) {
if (mode == Write)
- stats.write_misses++;
+ stats.writeMisses++;
else
- stats.read_misses++;
+ stats.readMisses++;
}
else {
if (mode == Write)
- stats.write_hits++;
+ stats.writeHits++;
else
- stats.read_hits++;
+ stats.readHits++;
}
DPRINTF(TLBVerbose, "lookup(vpn=%#x, asid=%#x): %s ppn %#x\n",
@@ -498,17 +498,17 @@
TLB::TlbStats::TlbStats(Stats::Group *parent)
: Stats::Group(parent),
- ADD_STAT(read_hits, UNIT_COUNT, "read hits"),
- ADD_STAT(read_misses, UNIT_COUNT, "read misses"),
- ADD_STAT(read_accesses, UNIT_COUNT, "read accesses"),
- ADD_STAT(write_hits, UNIT_COUNT, "write hits"),
- ADD_STAT(write_misses, UNIT_COUNT, "write misses"),
- ADD_STAT(write_accesses, UNIT_COUNT, "write accesses"),
+ ADD_STAT(readHits, UNIT_COUNT, "read hits"),
+ ADD_STAT(readMisses, UNIT_COUNT, "read misses"),
+ ADD_STAT(readAccesses, UNIT_COUNT, "read accesses"),
+ ADD_STAT(writeHits, UNIT_COUNT, "write hits"),
+ ADD_STAT(writeMisses, UNIT_COUNT, "write misses"),
+ ADD_STAT(writeAccesses, UNIT_COUNT, "write accesses"),
ADD_STAT(hits, UNIT_COUNT, "Total TLB (read and write) hits",
- read_hits + write_hits),
+ readHits + writeHits),
ADD_STAT(misses, UNIT_COUNT, "Total TLB (read and write) misses",
- read_misses + write_misses),
+ readMisses + writeMisses),
ADD_STAT(accesses, UNIT_COUNT, "Total TLB (read and write) accesses",
- read_accesses + write_accesses)
+ readAccesses + writeAccesses)
{
}
diff --git a/src/arch/riscv/tlb.hh b/src/arch/riscv/tlb.hh
index cb6059e..ef957be 100644
--- a/src/arch/riscv/tlb.hh
+++ b/src/arch/riscv/tlb.hh
@@ -67,14 +67,14 @@
struct TlbStats : public Stats::Group{
TlbStats(Stats::Group *parent);
- Stats::Scalar read_hits;
- Stats::Scalar read_misses;
+ Stats::Scalar readHits;
+ Stats::Scalar readMisses;
Stats::Scalar read_acv;
- Stats::Scalar read_accesses;
- Stats::Scalar write_hits;
- Stats::Scalar write_misses;
+ Stats::Scalar readAccesses;
+ Stats::Scalar writeHits;
+ Stats::Scalar writeMisses;
Stats::Scalar write_acv;
- Stats::Scalar write_accesses;
+ Stats::Scalar writeAccesses;
Stats::Formula hits;
Stats::Formula misses;
The change was submitted with unreviewed changes in the following files:
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/40695
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I397c9f165a53ecc120ec57f7214c90a65e12407e
Gerrit-Change-Number: 40695
Gerrit-PatchSet: 11
Gerrit-Owner: Hoa Nguyen <hoangu...@ucdavis.edu>
Gerrit-Reviewer: Bobby R. Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Daniel Carvalho <oda...@yahoo.com.br>
Gerrit-Reviewer: Hoa Nguyen <hoangu...@ucdavis.edu>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
