Daniel Carvalho has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/41334 )
Change subject: base: Add enum to_number tests
......................................................................
base: Add enum to_number tests
Add a test to convert a string containing a number into enums.
One of the tests has been disabled to highlight an error-prone
situation where a number that is not a valid enum manages to
be converted to an enum.
Change-Id: I7967c62feea335f3ffda40d8bf0334c20b53ee6c
Signed-off-by: Daniel R. Carvalho <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/41334
Tested-by: kokoro <[email protected]>
Reviewed-by: Bobby R. Bruce <[email protected]>
Maintainer: Bobby R. Bruce <[email protected]>
---
M src/base/str.test.cc
1 file changed, 24 insertions(+), 0 deletions(-)
Approvals:
Bobby R. Bruce: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/base/str.test.cc b/src/base/str.test.cc
index a064a87..f0cd483 100644
--- a/src/base/str.test.cc
+++ b/src/base/str.test.cc
@@ -301,6 +301,30 @@
EXPECT_FALSE(to_number(input, output));
}
+TEST(StrTest, ToNumberEnum)
+{
+ enum Number
+ {
+ TWO=2,
+ };
+ Number output;
+ std::string input = "2";
+ EXPECT_TRUE(to_number(input, output));
+ EXPECT_EQ(TWO, output);
+}
+
+/** Test that trying to convert a number to an enum that is not valid
fails. */
+TEST(StrTest, DISABLED_ToNumberEnumInvalid)
+{
+ enum Number
+ {
+ TWO=2,
+ };
+ Number output;
+ std::string input = "3";
+ EXPECT_FALSE(to_number(input, output));
+}
+
TEST(StrTest, ToNumberFloat)
{
float output;
The change was submitted with unreviewed changes in the following files:
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/41334
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I7967c62feea335f3ffda40d8bf0334c20b53ee6c
Gerrit-Change-Number: 41334
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
