Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/42095 )
Change subject: cpu: Get rid of the unused eaSrcsReady method.
......................................................................
cpu: Get rid of the unused eaSrcsReady method.
This method wasn't used by anything, and also made very unsafe
assumptions about what different source registers were used for.
Change-Id: I8f58aa70e139d3895499e04c86d8de2530e17d5a
---
M src/cpu/o3/dyn_inst.hh
M src/cpu/o3/dyn_inst_impl.hh
2 files changed, 0 insertions(+), 20 deletions(-)
diff --git a/src/cpu/o3/dyn_inst.hh b/src/cpu/o3/dyn_inst.hh
index 330c3e5..7ed4904 100644
--- a/src/cpu/o3/dyn_inst.hh
+++ b/src/cpu/o3/dyn_inst.hh
@@ -1022,9 +1022,6 @@
ThreadContext *tcBase() const override { return thread->getTC(); }
public:
- /** Returns whether or not the eff. addr. source registers are ready.
*/
- bool eaSrcsReady() const;
-
/** Is this instruction's memory access strictly ordered? */
bool strictlyOrdered() const { return instFlags[IsStrictlyOrdered]; }
void strictlyOrdered(bool so) { instFlags[IsStrictlyOrdered] = so; }
diff --git a/src/cpu/o3/dyn_inst_impl.hh b/src/cpu/o3/dyn_inst_impl.hh
index 5e4d3c1..7bb9dde 100644
--- a/src/cpu/o3/dyn_inst_impl.hh
+++ b/src/cpu/o3/dyn_inst_impl.hh
@@ -202,23 +202,6 @@
markSrcRegReady();
}
-template <class Impl>
-bool
-BaseO3DynInst<Impl>::eaSrcsReady() const
-{
- // For now I am assuming that src registers 1..n-1 are the ones that
the
- // EA calc depends on. (i.e. src reg 0 is the source of the data to be
- // stored)
-
- for (int i = 1; i < numSrcRegs(); ++i) {
- if (!regs.readySrcIdx(i))
- return false;
- }
-
- return true;
-}
-
-
template <class Impl>
void
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/42095
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I8f58aa70e139d3895499e04c86d8de2530e17d5a
Gerrit-Change-Number: 42095
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
