Matt Sinclair has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/42202 )
Change subject: gpu-compute: Remove unused functions
......................................................................
gpu-compute: Remove unused functions
These functions were probably used for some stat collection,
but they're no longer used, so they're being removed
Change-Id: Ic99f22391c0d5ffb0e9963670efb35e503f9957d
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/42202
Tested-by: kokoro <noreply+kok...@google.com>
Reviewed-by: Matt Sinclair <mattdsincl...@gmail.com>
Maintainer: Matt Sinclair <mattdsincl...@gmail.com>
---
M src/gpu-compute/gpu_dyn_inst.cc
M src/gpu-compute/gpu_dyn_inst.hh
2 files changed, 0 insertions(+), 37 deletions(-)
Approvals:
Matt Sinclair: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/gpu-compute/gpu_dyn_inst.cc
b/src/gpu-compute/gpu_dyn_inst.cc
index b827632..b9b23d4 100644
--- a/src/gpu-compute/gpu_dyn_inst.cc
+++ b/src/gpu-compute/gpu_dyn_inst.cc
@@ -268,40 +268,6 @@
return _staticInst->executed_as;
}
-bool
-GPUDynInst::hasVgprRawDependence(GPUDynInstPtr s)
-{
- assert(s);
- for (int i = 0; i < getNumOperands(); ++i) {
- if (isVectorRegister(i) && isSrcOperand(i)) {
- for (int j = 0; j < s->getNumOperands(); ++j) {
- if (s->isVectorRegister(j) && s->isDstOperand(j)) {
- if (i == j)
- return true;
- }
- }
- }
- }
- return false;
-}
-
-bool
-GPUDynInst::hasSgprRawDependence(GPUDynInstPtr s)
-{
- assert(s);
- for (int i = 0; i < getNumOperands(); ++i) {
- if (isScalarRegister(i) && isSrcOperand(i)) {
- for (int j = 0; j < s->getNumOperands(); ++j) {
- if (s->isScalarRegister(j) && s->isDstOperand(j)) {
- if (i == j)
- return true;
- }
- }
- }
- }
- return false;
-}
-
// Process a memory instruction and (if necessary) submit timing request
void
GPUDynInst::initiateAcc(GPUDynInstPtr gpuDynInst)
diff --git a/src/gpu-compute/gpu_dyn_inst.hh
b/src/gpu-compute/gpu_dyn_inst.hh
index 851a46a..97eea01 100644
--- a/src/gpu-compute/gpu_dyn_inst.hh
+++ b/src/gpu-compute/gpu_dyn_inst.hh
@@ -101,9 +101,6 @@
bool hasDestinationVgpr() const;
bool hasSourceVgpr() const;
- bool hasSgprRawDependence(GPUDynInstPtr s);
- bool hasVgprRawDependence(GPUDynInstPtr s);
-
// returns true if the string "opcodeStr" is found in the
// opcode of the instruction
bool isOpcode(const std::string& opcodeStr) const;
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/42202
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ic99f22391c0d5ffb0e9963670efb35e503f9957d
Gerrit-Change-Number: 42202
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Dutu <alexandru.d...@amd.com>
Gerrit-Reviewer: Matt Sinclair <mattdsincl...@gmail.com>
Gerrit-Reviewer: Matthew Poremba <matthew.pore...@amd.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-CC: Kyle Roarty <kyleroarty1...@gmail.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
