[gem5-dev] Change in gem5/gem5[develop]: base: Add warnings for legacy stats

[Hoa Nguyen (Gerrit) via gem5-dev]

Hoa Nguyen has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/44706 )

Change subject: base: Add warnings for legacy stats
......................................................................

base: Add warnings for legacy stats

Legacy stat is defined as a stat that doesn't belong to any
Stats::Group.

Change-Id: I8d426882b6bf7600998e181f18d1339ce82d5917
Signed-off-by: Hoa Nguyen <hoangu...@ucdavis.edu>
---
M src/base/statistics.hh
1 file changed, 34 insertions(+), 3 deletions(-)



diff --git a/src/base/statistics.hh b/src/base/statistics.hh
index 63bfb5b..548c351 100644
--- a/src/base/statistics.hh
+++ b/src/base/statistics.hh
@@ -546,6 +546,10 @@
         : DataWrap<Derived, ScalarInfoProxy>(parent, name, unit, desc)
     {
         this->doInit();
+        if (parent == nullptr && name != nullptr)
+            warn(csprintf("`%s` is a legacy stat", name));
+        else if (parent == nullptr)
+            warn_once("Legacy stat exists");
     }

   public:
@@ -704,6 +708,10 @@
         : DataWrap<Derived, ScalarInfoProxy>(parent, name, unit, desc),
           proxy(NULL)
     {
+        if (parent == nullptr && name != nullptr)
+            warn(csprintf("`%s` is a legacy stat", name));
+        else if (parent == nullptr)
+            warn_once("Legacy stat exists");
     }

     ~ValueBase() { if (proxy) delete proxy; }
@@ -1007,7 +1015,12 @@
                const char *desc)
         : DataWrapVec<Derived, VectorInfoProxy>(parent, name, unit, desc),
           storage(nullptr), _size(0)
-    {}
+    {
+        if (parent == nullptr && name != nullptr)
+            warn(csprintf("`%s` is a legacy stat", name));
+        else if (parent == nullptr)
+            warn_once("Legacy stat exists");
+    }

     ~VectorBase()
     {
@@ -1150,7 +1163,12 @@
                  const char *desc)
         : DataWrapVec2d<Derived, Vector2dInfoProxy>(parent, name, unit,  
desc),
           x(0), y(0), _size(0), storage(nullptr)
-    {}
+    {
+        if (parent == nullptr && name != nullptr)
+            warn(csprintf("`%s` is a legacy stat", name));
+        else if (parent == nullptr)
+            warn_once("Legacy stat exists");
+    }

     ~Vector2dBase()
     {
@@ -1311,6 +1329,10 @@
              const char *desc)
         : DataWrap<Derived, DistInfoProxy>(parent, name, unit, desc)
     {
+        if (parent == nullptr && name != nullptr)
+            warn(csprintf("`%s` is a legacy stat", name));
+        else if (parent == nullptr)
+            warn_once("Legacy stat exists");
     }

     /**
@@ -1409,7 +1431,12 @@
                    const char *desc)
         : DataWrapVec<Derived, VectorDistInfoProxy>(parent, name, unit,  
desc),
           storage(NULL)
-    {}
+    {
+        if (parent == nullptr && name != nullptr)
+            warn(csprintf("`%s` is a legacy stat", name));
+        else if (parent == nullptr)
+            warn_once("Legacy stat exists");
+    }

     ~VectorDistBase()
     {
@@ -2452,6 +2479,10 @@
                    const char *desc)
         : DataWrap<Derived, SparseHistInfoProxy>(parent, name, unit, desc)
     {
+        if (parent == nullptr && name != nullptr)
+            warn(csprintf("`%s` is a legacy stat", name));
+        else if (parent == nullptr)
+            warn_once("Legacy stat exists");
     }

     /**

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/44706
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I8d426882b6bf7600998e181f18d1339ce82d5917
Gerrit-Change-Number: 44706
Gerrit-PatchSet: 1
Gerrit-Owner: Hoa Nguyen <hoangu...@ucdavis.edu>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s