Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/45165 )
Change subject: tests: Delete the nmtest "UnitTest".
......................................................................
tests: Delete the nmtest "UnitTest".
This "UnitTest" actually links against all of gem5, and can be used to
look at a binary and find either what symbol goes with an address, or
what address goes with a symbol.
While that could be a useful thing to want to do, there are other ways
to do that with external tools. Also, other than by seeing if this tool
compiles and manually seeing if it returns reasonable results, this
doesn't really actually test anything.
Finally, this is one of the old style "UnitTest"s, quotes intentional,
since while it may try to do a fairly specific thing, it actually
exercises an arbitrarily large portion of gem5 as a whole to do it, does
not self report success or failure, contain any test cases or input data
or expected output, and is not run automatically as part of our testing
suite.
Tests for the underlying classes in the Loader namespace would be/are
more appropriate, and make this test unnecessary.
Change-Id: I48db315d3da440fd26be0a81cc8e07affcacda46
---
M src/unittest/SConscript
D src/unittest/nmtest.cc
2 files changed, 0 insertions(+), 74 deletions(-)
diff --git a/src/unittest/SConscript b/src/unittest/SConscript
index 5008066..43eb16a 100644
--- a/src/unittest/SConscript
+++ b/src/unittest/SConscript
@@ -28,7 +28,5 @@
Import('*')
-UnitTest('nmtest', 'nmtest.cc')
-
stattest_py = PySource('m5', 'stattestmain.py', tags='stattest')
UnitTest('stattest', 'stattest.cc', with_tag('stattest'), main=True)
diff --git a/src/unittest/nmtest.cc b/src/unittest/nmtest.cc
deleted file mode 100644
index fd24524..0000000
--- a/src/unittest/nmtest.cc
+++ /dev/null
@@ -1,72 +0,0 @@
-/*
- * Copyright (c) 2002-2005 The Regents of The University of Michigan
- * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met: redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer;
- * redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution;
- * neither the name of the copyright holders nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include <iostream>
-#include <string>
-#include <vector>
-
-#include "base/loader/object_file.hh"
-#include "base/logging.hh"
-#include "base/str.hh"
-
-int
-main(int argc, char *argv[])
-{
- if (argc != 2 && argc != 3)
- panic("usage: %s <filename> <symbol>\n", argv[0]);
-
- auto *obj = Loader::createObjectFile(argv[1]);
- if (!obj)
- panic("file not found\n");
-
- if (argc == 2) {
- for (const Loader::Symbol &symbol: obj->symtab())
- cprintf("%#x %s\n", symbol.address, symbol.name);
- } else {
- std::string symbol = argv[2];
- Addr address;
-
- if (symbol[0] == '0' && symbol[1] == 'x') {
- Loader::SymbolTable::const_iterator it;
- if (to_number(symbol, address) &&
- (it = obj->symtab().find(address)) != obj->symtab().end())
{
- cprintf("address = %#x, symbol = %s\n", address, it->name);
- } else {
- cprintf("address = %#x was not found\n", address);
- }
- } else {
- auto it = obj->symtab().find(symbol);
- if (it != obj->symtab().end())
- cprintf("symbol = %s address = %#x\n", symbol,
it->address);
- else
- cprintf("symbol = %s was not found\n", symbol);
- }
- }
-
- return 0;
-}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/45165
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I48db315d3da440fd26be0a81cc8e07affcacda46
Gerrit-Change-Number: 45165
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
