Matthew Poremba has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/45499 )
Change subject: arch-vega,arch-gcn3: Fix s_cmp_lt_u32
......................................................................
arch-vega,arch-gcn3: Fix s_cmp_lt_u32
Was using less-than-or-equal rather than less-than. All other comparison
instructions look correct otherwise.
Change-Id: Iee0374554f21a80a6da2eb75f38b22c83b6e1e9c
---
M src/arch/amdgpu/gcn3/insts/instructions.cc
M src/arch/amdgpu/vega/insts/instructions.cc
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/arch/amdgpu/gcn3/insts/instructions.cc
b/src/arch/amdgpu/gcn3/insts/instructions.cc
index 8cadff7..2761008 100644
--- a/src/arch/amdgpu/gcn3/insts/instructions.cc
+++ b/src/arch/amdgpu/gcn3/insts/instructions.cc
@@ -3496,7 +3496,7 @@
src0.read();
src1.read();
- scc = (src0.rawData() <= src1.rawData()) ? 1 : 0;
+ scc = (src0.rawData() < src1.rawData()) ? 1 : 0;
scc.write();
}
diff --git a/src/arch/amdgpu/vega/insts/instructions.cc
b/src/arch/amdgpu/vega/insts/instructions.cc
index 0a01bf2..5db3e54 100644
--- a/src/arch/amdgpu/vega/insts/instructions.cc
+++ b/src/arch/amdgpu/vega/insts/instructions.cc
@@ -3832,7 +3832,7 @@
src0.read();
src1.read();
- scc = (src0.rawData() <= src1.rawData()) ? 1 : 0;
+ scc = (src0.rawData() < src1.rawData()) ? 1 : 0;
scc.write();
} // execute
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/45499
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Iee0374554f21a80a6da2eb75f38b22c83b6e1e9c
Gerrit-Change-Number: 45499
Gerrit-PatchSet: 1
Gerrit-Owner: Matthew Poremba <matthew.pore...@amd.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s