Bobby R. Bruce has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/45999 )
Change subject: tests: Add sleep and debug to the jenkins presubmit.sh
......................................................................
tests: Add sleep and debug to the jenkins presubmit.sh
This is patch is in regard to issues discussed here:
https://www.mail-archive.com/[email protected]/msg39122.html
The aim of this patch is to set a potential fix, and to give more
valuable debugging information.
It is not known why Kokoro sometimes fails, but it may be due to the
Docker service not starting fully prior to execution of the tests
within a Docker container. As such a 2 second sleep has been added
between starting the Docker service and running the tests.
The pulling of the docker images has been separated out to run at the
start of testing. This should help us determine whether the issue lays
with the pulling of an image or the running of a container.
The bash debug flag `-x` has been set so the expansion of each line can
be determined upon the event of a failure.
This patch will be reverted if it is found to not solve the issue.
Change-Id: I0d2dd8a080f64296e55f4b6de9a036d94d19c8ac
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/45999
Reviewed-by: Matt Sinclair <[email protected]>
Maintainer: Gabe Black <[email protected]>
Tested-by: kokoro <[email protected]>
---
M tests/jenkins/presubmit.sh
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Matt Sinclair: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/tests/jenkins/presubmit.sh b/tests/jenkins/presubmit.sh
index f27c23c..7b59f55 100755
--- a/tests/jenkins/presubmit.sh
+++ b/tests/jenkins/presubmit.sh
@@ -36,6 +36,7 @@
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
set -e
+set -x
DOCKER_IMAGE_ALL_DEP=gcr.io/gem5-test/ubuntu-20.04_all-dependencies
DOCKER_IMAGE_CLANG_COMPILE=gcr.io/gem5-test/clang-version-9
@@ -47,6 +48,14 @@
sudo ln -s /tmpfs/docker /var/lib/docker
sudo /etc/init.d/docker start
+# This is a conservative step to ensure the docker service is fully running
+# prior to executing the tests.
+sleep 2
+
+# Pull the docker images we require
+docker pull "${DOCKER_IMAGE_ALL_DEP}"
+docker pull "${DOCKER_IMAGE_CLANG_COMPILE}"
+
# Move the CWD to the gem5 checkout.
cd git/jenkins-gem5-prod/
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/45999
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I0d2dd8a080f64296e55f4b6de9a036d94d19c8ac
Gerrit-Change-Number: 45999
Gerrit-PatchSet: 3
Gerrit-Owner: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Matt Sinclair <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
