Daniel Carvalho has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/44112 )
Change subject: base: Add error messages to BloomFilter::Perfect
......................................................................
base: Add error messages to BloomFilter::Perfect
Warn the user when they use BloomFilter::Perfect's
parameters incorrectly.
Change-Id: Ib493c5f508e47a5f18e43c023755ef960954f5cc
Signed-off-by: Daniel R. Carvalho <oda...@yahoo.com.br>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/44112
Reviewed-by: Giacomo Travaglini <giacomo.travagl...@arm.com>
Maintainer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/base/filters/BloomFilters.py
M src/base/filters/perfect_bloom_filter.cc
2 files changed, 12 insertions(+), 0 deletions(-)
Approvals:
Giacomo Travaglini: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/base/filters/BloomFilters.py
b/src/base/filters/BloomFilters.py
index 02d2052..7832f47 100644
--- a/src/base/filters/BloomFilters.py
+++ b/src/base/filters/BloomFilters.py
@@ -98,3 +98,8 @@
# The base filter is not needed. Use a dummy value.
size = 1
+
+ # This filter does not use saturating counters - as long as the entry
is
+ # set, it is present; thus, it only needs one bit.
+ num_bits = 1
+ threshold = 1
diff --git a/src/base/filters/perfect_bloom_filter.cc
b/src/base/filters/perfect_bloom_filter.cc
index 0424ddc..7583a1a 100644
--- a/src/base/filters/perfect_bloom_filter.cc
+++ b/src/base/filters/perfect_bloom_filter.cc
@@ -28,6 +28,7 @@
#include "base/filters/perfect_bloom_filter.hh"
+#include "base/logging.hh"
#include "params/BloomFilterPerfect.hh"
namespace gem5
@@ -40,6 +41,12 @@
Perfect::Perfect(const BloomFilterPerfectParams &p)
: Base(p)
{
+ fatal_if(p.size != 1, "The perfect Bloom filter cannot be limited to
a "
+ "specific size.");
+ fatal_if(p.num_bits != 1, "The perfect Bloom filter tracks entries "
+ "perfectly using an unlimited amount of 1-bit entries.");
+ fatal_if(p.threshold != 1, "The perfect Bloom filter uses 1-bit
entries; "
+ "thus, their thresholds must be 1.");
}
Perfect::~Perfect()
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/44112
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ib493c5f508e47a5f18e43c023755ef960954f5cc
Gerrit-Change-Number: 44112
Gerrit-PatchSet: 9
Gerrit-Owner: Daniel Carvalho <oda...@yahoo.com.br>
Gerrit-Reviewer: Bobby R. Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Daniel Carvalho <oda...@yahoo.com.br>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
