Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/48129 )
Change subject: scons: Use sets instead of lists to track needed target
environments.
......................................................................
scons: Use sets instead of lists to track needed target environments.
This simple change intrinsically collapses away duplicates.
Change-Id: I697c21897a81c47cbf540caa49806413dce80dba
---
M src/SConscript
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/SConscript b/src/SConscript
index 7b62724..196b80c 100644
--- a/src/SConscript
+++ b/src/SConscript
@@ -1414,7 +1414,7 @@
# need. We try to identify the needed environment for each target; if
# we can't, we fall back on instantiating all the environments just to
# be safe.
-target_types = ['debug', 'opt', 'fast', 'prof', 'perf']
+target_types = {'debug', 'opt', 'fast', 'prof', 'perf'}
obj2target = {'do': 'debug', 'o': 'opt', 'fo': 'fast', 'po': 'prof',
'gpo' : 'perf'}
@@ -1426,9 +1426,9 @@
return obj2target[ext]
return 'all'
-needed_envs = [identifyTarget(target) for target in BUILD_TARGETS]
+needed_envs = {identifyTarget(target) for target in BUILD_TARGETS}
if 'all' in needed_envs:
- needed_envs += target_types
+ needed_envs = target_types
# Debug binary
if 'debug' in needed_envs:
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/48129
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I697c21897a81c47cbf540caa49806413dce80dba
Gerrit-Change-Number: 48129
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
