Giacomo Travaglini has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/48686 )
Change subject: cpu: MiscReg read/writes polluting ExecContext integer stats
......................................................................
cpu: MiscReg read/writes polluting ExecContext integer stats
Change-Id: Ic505c1157f9008f19bfc500b8f20334c63a64106
Signed-off-by: Giacomo Travaglini <giacomo.travagl...@arm.com>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/48686
Reviewed-by: Gabe Black <gabe.bl...@gmail.com>
Reviewed-by: Jason Lowe-Power <power...@gmail.com>
Maintainer: Gabe Black <gabe.bl...@gmail.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/cpu/simple/exec_context.hh
1 file changed, 13 insertions(+), 5 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved
Gabe Black: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/cpu/simple/exec_context.hh b/src/cpu/simple/exec_context.hh
index 23e6e47..7614491 100644
--- a/src/cpu/simple/exec_context.hh
+++ b/src/cpu/simple/exec_context.hh
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2014-2018, 2020 ARM Limited
+ * Copyright (c) 2014-2018, 2020-2021 Arm Limited
* All rights reserved
*
* The license below extends only to copyright in the software and shall
@@ -128,6 +128,10 @@
"Number of times the CC registers were read"),
ADD_STAT(numCCRegWrites, statistics::units::Count::get(),
"Number of times the CC registers were written"),
+ ADD_STAT(numMiscRegReads, statistics::units::Count::get(),
+ "Number of times the Misc registers were read"),
+ ADD_STAT(numMiscRegWrites, statistics::units::Count::get(),
+ "Number of times the Misc registers were written"),
ADD_STAT(numMemRefs, statistics::units::Count::get(),
"Number of memory refs"),
ADD_STAT(numLoadInsts, statistics::units::Count::get(),
@@ -237,6 +241,10 @@
statistics::Scalar numCCRegReads;
statistics::Scalar numCCRegWrites;
+ // Number of misc register file accesses
+ statistics::Scalar numMiscRegReads;
+ statistics::Scalar numMiscRegWrites;
+
// Number of simulated memory references
statistics::Scalar numMemRefs;
statistics::Scalar numLoadInsts;
@@ -423,7 +431,7 @@
RegVal
readMiscRegOperand(const StaticInst *si, int idx) override
{
- execContextStats.numIntRegReads++;
+ execContextStats.numMiscRegReads++;
const RegId& reg = si->srcRegIdx(idx);
assert(reg.is(MiscRegClass));
return thread->readMiscReg(reg.index());
@@ -432,7 +440,7 @@
void
setMiscRegOperand(const StaticInst *si, int idx, RegVal val) override
{
- execContextStats.numIntRegWrites++;
+ execContextStats.numMiscRegWrites++;
const RegId& reg = si->destRegIdx(idx);
assert(reg.is(MiscRegClass));
thread->setMiscReg(reg.index(), val);
@@ -445,7 +453,7 @@
RegVal
readMiscReg(int misc_reg) override
{
- execContextStats.numIntRegReads++;
+ execContextStats.numMiscRegReads++;
return thread->readMiscReg(misc_reg);
}
@@ -456,7 +464,7 @@
void
setMiscReg(int misc_reg, RegVal val) override
{
- execContextStats.numIntRegWrites++;
+ execContextStats.numMiscRegWrites++;
thread->setMiscReg(misc_reg, val);
}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/48686
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ic505c1157f9008f19bfc500b8f20334c63a64106
Gerrit-Change-Number: 48686
Gerrit-PatchSet: 2
Gerrit-Owner: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-Reviewer: Jason Lowe-Power <power...@gmail.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
