Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/45229 )
Change subject: arch,cpu: Rename RegClass to RegClassType.
......................................................................
arch,cpu: Rename RegClass to RegClassType.
This type is really an index which selects a RegClass, not a RegClass
itself.
A follow on change will rename RegClassInfo to RegClass.
Change-Id: I2c1b1d4105bd11b58680053b484d4c1aa1055a9f
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/45229
Maintainer: Gabe Black <gabe.bl...@gmail.com>
Maintainer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Reviewed-by: Giacomo Travaglini <giacomo.travagl...@arm.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/arch/arm/tracers/tarmac_record.hh
M src/cpu/o3/regfile.cc
M src/cpu/o3/regfile.hh
M src/cpu/reg_class.hh
4 files changed, 12 insertions(+), 11 deletions(-)
Approvals:
Giacomo Travaglini: Looks good to me, approved; Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/arm/tracers/tarmac_record.hh
b/src/arch/arm/tracers/tarmac_record.hh
index a1d42b2..fb45e9e 100644
--- a/src/arch/arm/tracers/tarmac_record.hh
+++ b/src/arch/arm/tracers/tarmac_record.hh
@@ -162,7 +162,7 @@
/** True if register entry is valid */
bool regValid;
/** Register class */
- RegClass regClass;
+ RegClassType regClass;
/** Register arch number */
RegIndex regRel;
/** Register name to be printed */
diff --git a/src/cpu/o3/regfile.cc b/src/cpu/o3/regfile.cc
index df9dd78..f2f0111 100644
--- a/src/cpu/o3/regfile.cc
+++ b/src/cpu/o3/regfile.cc
@@ -196,7 +196,7 @@
}
PhysRegFile::IdRange
-PhysRegFile::getRegIds(RegClass cls)
+PhysRegFile::getRegIds(RegClassType cls)
{
switch (cls)
{
diff --git a/src/cpu/o3/regfile.hh b/src/cpu/o3/regfile.hh
index c7cf807..8101d53 100644
--- a/src/cpu/o3/regfile.hh
+++ b/src/cpu/o3/regfile.hh
@@ -357,7 +357,7 @@
* Auxiliary function to transition from Full vector mode to Elem mode
* and to initialise the rename map.
*/
- IdRange getRegIds(RegClass cls);
+ IdRange getRegIds(RegClassType cls);
/**
* Get the true physical register id.
diff --git a/src/cpu/reg_class.hh b/src/cpu/reg_class.hh
index 0b57487..f7a4d1c 100644
--- a/src/cpu/reg_class.hh
+++ b/src/cpu/reg_class.hh
@@ -53,7 +53,7 @@
{
/** Enumerate the classes of registers. */
-enum RegClass
+enum RegClassType
{
IntRegClass, ///< Integer register
FloatRegClass, ///< Floating-point register
@@ -114,7 +114,7 @@
{
protected:
static const char* regClassStrings[];
- RegClass regClass;
+ RegClassType regClass;
RegIndex regIdx;
ElemIndex elemIdx;
static constexpr size_t Scale = TheISA::NumVecElemPerVecReg;
@@ -125,10 +125,11 @@
public:
RegId() : RegId(IntRegClass, 0) {}
- RegId(RegClass reg_class, RegIndex reg_idx)
+ RegId(RegClassType reg_class, RegIndex reg_idx)
: RegId(reg_class, reg_idx, IllegalElemIndex) {}
- explicit RegId(RegClass reg_class, RegIndex reg_idx, ElemIndex
elem_idx)
+ explicit RegId(RegClassType reg_class, RegIndex reg_idx,
+ ElemIndex elem_idx)
: regClass(reg_class), regIdx(reg_idx), elemIdx(elem_idx),
numPinnedWrites(0)
{
@@ -172,7 +173,7 @@
}
/** @return true if it is of the specified class. */
- bool is(RegClass reg_class) const { return regClass == reg_class; }
+ bool is(RegClassType reg_class) const { return regClass == reg_class; }
/** Index accessors */
/** @{ */
@@ -202,7 +203,7 @@
/** Elem accessor */
RegIndex elemIndex() const { return elemIdx; }
/** Class accessor */
- RegClass classValue() const { return regClass; }
+ RegClassType classValue() const { return regClass; }
/** Return a const char* with the register class name. */
const char* className() const { return regClassStrings[regClass]; }
@@ -233,14 +234,14 @@
{}
/** Scalar PhysRegId constructor. */
- explicit PhysRegId(RegClass _regClass, RegIndex _regIdx,
+ explicit PhysRegId(RegClassType _regClass, RegIndex _regIdx,
RegIndex _flatIdx)
: RegId(_regClass, _regIdx), flatIdx(_flatIdx),
numPinnedWritesToComplete(0), pinned(false)
{}
/** Vector PhysRegId constructor (w/ elemIndex). */
- explicit PhysRegId(RegClass _regClass, RegIndex _regIdx,
+ explicit PhysRegId(RegClassType _regClass, RegIndex _regIdx,
ElemIndex elem_idx, RegIndex flat_idx)
: RegId(_regClass, _regIdx, elem_idx), flatIdx(flat_idx),
numPinnedWritesToComplete(0), pinned(false)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/45229
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I2c1b1d4105bd11b58680053b484d4c1aa1055a9f
Gerrit-Change-Number: 45229
Gerrit-PatchSet: 8
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
