Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/48121 )

Change subject: scons: Get rid of the unused "dirname" property of SourceFile.
......................................................................

scons: Get rid of the unused "dirname" property of SourceFile.

Change-Id: I7c52f866542057b9f11ba96434f9c6f93ff0ea46
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/48121
Reviewed-by: Bobby R. Bruce <bbr...@ucdavis.edu>
Maintainer: Bobby R. Bruce <bbr...@ucdavis.edu>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/SConscript
1 file changed, 0 insertions(+), 4 deletions(-)

Approvals:
  Bobby R. Bruce: Looks good to me, approved; Looks good to me, approved
  kokoro: Regressions pass



diff --git a/src/SConscript b/src/SConscript
index e4f0c42..a4b35cd 100644
--- a/src/SConscript
+++ b/src/SConscript
@@ -278,10 +278,6 @@
         return str(self.tnode)

     @property
-    def dirname(self):
-        return dirname(self.filename)
-
-    @property
     def basename(self):
         return basename(self.filename)


--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/48121
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I7c52f866542057b9f11ba96434f9c6f93ff0ea46
Gerrit-Change-Number: 48121
Gerrit-PatchSet: 3
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-Reviewer: Bobby R. Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Nikos Nikoleris <nikos.nikole...@arm.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to