Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/49390 )

Change subject: scons: Get rid of a loop which touched all the param ptype attributes.
......................................................................

scons: Get rid of a loop which touched all the param ptype attributes.

As far as I can tell, this code is left over from when gem5 used SWIG,
and is not necessary any more.

Change-Id: Id36887773d2fc1373ffe689ee1b50b4989bf5a38
---
M src/SConscript
1 file changed, 0 insertions(+), 8 deletions(-)



diff --git a/src/SConscript b/src/SConscript
index cbc398a..429d0da 100644
--- a/src/SConscript
+++ b/src/SConscript
@@ -681,14 +681,6 @@
 sim_objects = m5.SimObject.allClasses
 all_enums = m5.params.allEnums

-for name,obj in sorted(sim_objects.items()):
-    for param in obj._params.local.values():
-        # load the ptype attribute now because it depends on the
-        # current version of SimObject.allClasses, but when scons
-        # actually uses the value, all versions of
-        # SimObject.allClasses will have been loaded
-        param.ptype
-
 ########################################################################
 #
 # calculate extra dependencies

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/49390
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Id36887773d2fc1373ffe689ee1b50b4989bf5a38
Gerrit-Change-Number: 49390
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to