Hoa Nguyen has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/50627 )
Change subject: scons: Fix gem5 build fails when install-hooks is not set
......................................................................
scons: Fix gem5 build fails when install-hooks is not set
For interactive build, gem5 build fails when the git-hooks
is not available since scons would look for `install-hooks`
option, which is not necessarily set for interactive build.
JIRA: https://gem5.atlassian.net/browse/GEM5-1091
Signed-off-by: Hoa Nguyen <hoangu...@ucdavis.edu>
Change-Id: Ife248117420eb470c02d6e7536c1065256ba71e0
---
M site_scons/site_tools/git.py
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/site_scons/site_tools/git.py b/site_scons/site_tools/git.py
index e95c62f..3a23276 100644
--- a/site_scons/site_tools/git.py
+++ b/site_scons/site_tools/git.py
@@ -100,9 +100,10 @@
return
print(git_style_message, end=' ')
- if SCons.Script.GetOption('install-hooks'):
- print("Installing revision control hooks automatically.")
- else:
+ try:
+ if SCons.Script.GetOption('install-hooks'):
+ print("Installing revision control hooks automatically.")
+ except AttributeError:
try:
input()
except:
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/50627
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ife248117420eb470c02d6e7536c1065256ba71e0
Gerrit-Change-Number: 50627
Gerrit-PatchSet: 1
Gerrit-Owner: Hoa Nguyen <hoangu...@ucdavis.edu>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s