Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/50765 )

Change subject: misc: Remove include of arch/page_size.hh, and fix up includes.
......................................................................

misc: Remove include of arch/page_size.hh, and fix up includes.

Remove the only remaining use of arch/page_size.hh, and fix up a couple
files which were using one of the constants defined in a specific arch
version of it without including the file they needed directly.

Change-Id: I6da5638ca10c788bd42197f4f5180e6b66f7b87f
---
M src/arch/arm/system.hh
M src/arch/riscv/pagetable_walker.cc
M src/dev/arm/generic_timer.cc
M src/gpu-compute/gpu_compute_driver.cc
M src/sim/system.hh
5 files changed, 4 insertions(+), 1 deletion(-)



diff --git a/src/arch/arm/system.hh b/src/arch/arm/system.hh
index f2ec5c3..a163ee4 100644
--- a/src/arch/arm/system.hh
+++ b/src/arch/arm/system.hh
@@ -45,6 +45,7 @@
 #include <string>
 #include <vector>

+#include "arch/arm/page_size.hh"
 #include "kern/linux/events.hh"
 #include "params/ArmSystem.hh"
 #include "sim/full_system.hh"
diff --git a/src/arch/riscv/pagetable_walker.cc b/src/arch/riscv/pagetable_walker.cc
index bc15524..08767c2 100644
--- a/src/arch/riscv/pagetable_walker.cc
+++ b/src/arch/riscv/pagetable_walker.cc
@@ -53,6 +53,7 @@
 #include <memory>

 #include "arch/riscv/faults.hh"
+#include "arch/riscv/page_size.hh"
 #include "arch/riscv/pagetable.hh"
 #include "arch/riscv/tlb.hh"
 #include "base/bitfield.hh"
diff --git a/src/dev/arm/generic_timer.cc b/src/dev/arm/generic_timer.cc
index 52f41fe..ba46fcd 100644
--- a/src/dev/arm/generic_timer.cc
+++ b/src/dev/arm/generic_timer.cc
@@ -39,6 +39,7 @@

 #include <cmath>

+#include "arch/arm/page_size.hh"
 #include "arch/arm/system.hh"
 #include "arch/arm/utility.hh"
 #include "base/logging.hh"
diff --git a/src/gpu-compute/gpu_compute_driver.cc b/src/gpu-compute/gpu_compute_driver.cc
index 3adfadd..1069220 100644
--- a/src/gpu-compute/gpu_compute_driver.cc
+++ b/src/gpu-compute/gpu_compute_driver.cc
@@ -35,6 +35,7 @@

 #include <memory>

+#include "arch/x86/page_size.hh"
 #include "base/compiler.hh"
 #include "base/logging.hh"
 #include "base/trace.hh"
diff --git a/src/sim/system.hh b/src/sim/system.hh
index f25d279..7aeeea7 100644
--- a/src/sim/system.hh
+++ b/src/sim/system.hh
@@ -48,7 +48,6 @@
 #include <utility>
 #include <vector>

-#include "arch/page_size.hh"
 #include "base/loader/memory_image.hh"
 #include "base/loader/symtab.hh"
 #include "base/statistics.hh"

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/50765
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I6da5638ca10c788bd42197f4f5180e6b66f7b87f
Gerrit-Change-Number: 50765
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to