Matthew Poremba has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/47103 )
6 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
Change subject: arch-vega: Add missing functions referenced by insts
......................................................................
arch-vega: Add missing functions referenced by insts
Some instructions were referencing pc() and isExecMaskRegister() which
were not defined.
Change-Id: Ic5b3fa9057950ff85603fcb87447a81b6c7f274b
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/47103
Tested-by: kokoro <noreply+kok...@google.com>
Reviewed-by: Matt Sinclair <mattdsincl...@gmail.com>
Maintainer: Matt Sinclair <mattdsincl...@gmail.com>
---
M src/arch/amdgpu/vega/insts/gpu_static_inst.hh
M src/gpu-compute/gpu_dyn_inst.cc
M src/gpu-compute/gpu_dyn_inst.hh
3 files changed, 21 insertions(+), 0 deletions(-)
Approvals:
Matt Sinclair: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/amdgpu/vega/insts/gpu_static_inst.hh
b/src/arch/amdgpu/vega/insts/gpu_static_inst.hh
index 64151f7..fa2a8e1 100644
--- a/src/arch/amdgpu/vega/insts/gpu_static_inst.hh
+++ b/src/arch/amdgpu/vega/insts/gpu_static_inst.hh
@@ -60,6 +60,12 @@
return isFlatScratchReg(opIdx);
}
+ bool
+ isExecMaskRegister(int opIdx) override
+ {
+ return isExecMask(opIdx);
+ }
+
void initOperandInfo() override { return; }
int getOperandSize(int opIdx) override { return 0; }
diff --git a/src/gpu-compute/gpu_dyn_inst.cc
b/src/gpu-compute/gpu_dyn_inst.cc
index 937e572..1eadfa9 100644
--- a/src/gpu-compute/gpu_dyn_inst.cc
+++ b/src/gpu-compute/gpu_dyn_inst.cc
@@ -284,6 +284,18 @@
return _seqNum;
}
+Addr
+GPUDynInst::pc()
+{
+ return wavefront()->pc();
+}
+
+void
+GPUDynInst::pc(Addr _pc)
+{
+ wavefront()->pc(_pc);
+}
+
enums::StorageClassType
GPUDynInst::executedAs()
{
diff --git a/src/gpu-compute/gpu_dyn_inst.hh
b/src/gpu-compute/gpu_dyn_inst.hh
index ae8260e..f673afe 100644
--- a/src/gpu-compute/gpu_dyn_inst.hh
+++ b/src/gpu-compute/gpu_dyn_inst.hh
@@ -162,6 +162,9 @@
InstSeqNum seqNum() const;
+ Addr pc();
+ void pc(Addr _pc);
+
enums::StorageClassType executedAs();
// virtual address for scalar memory operations
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/47103
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ic5b3fa9057950ff85603fcb87447a81b6c7f274b
Gerrit-Change-Number: 47103
Gerrit-PatchSet: 8
Gerrit-Owner: Matthew Poremba <matthew.pore...@amd.com>
Gerrit-Reviewer: Alex Dutu <alexandru.d...@amd.com>
Gerrit-Reviewer: Kyle Roarty <kyleroarty1...@gmail.com>
Gerrit-Reviewer: Matt Sinclair <mattdsincl...@gmail.com>
Gerrit-Reviewer: Matthew Poremba <matthew.pore...@amd.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-CC: Jason Lowe-Power <power...@gmail.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
