Giacomo Travaglini has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/51007 )

Change subject: configs: Remove lpae and virtualisation options
......................................................................

configs: Remove lpae and virtualisation options

lpae is already defaulting to True in the ArmSystem, so the check is
useless (args.lpae cannot clear system.lpae)

If you want to run an hypervisor, you shouldn't be using fs.py in the
first place

Change-Id: I4d631561d62399b946106a90c14454115040c206
Signed-off-by: Giacomo Travaglini <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/51007
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
Tested-by: kokoro <[email protected]>
---
M configs/common/Options.py
M configs/example/fs.py
2 files changed, 0 insertions(+), 9 deletions(-)

Approvals:
  Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
  kokoro: Regressions pass




diff --git a/configs/common/Options.py b/configs/common/Options.py
index 7d72d4a..4e696ef 100644
--- a/configs/common/Options.py
+++ b/configs/common/Options.py
@@ -260,9 +260,6 @@
                       Elastic Trace probe in a capture simulation and
                       Trace CPU in a replay simulation""", default="")

-    parser.add_argument("-l", "--lpae", action="store_true")
-    parser.add_argument("-V", "--virtualisation", action="store_true")
-
     # dist-gem5 options
     parser.add_argument("--dist", action="store_true",
                         help="Parallel distributed gem5 simulation.")
diff --git a/configs/example/fs.py b/configs/example/fs.py
index dab28b1..cdb2a49 100644
--- a/configs/example/fs.py
+++ b/configs/example/fs.py
@@ -132,12 +132,6 @@
     if args.script is not None:
         test_sys.readfile = args.script

-    if args.lpae:
-        test_sys.have_lpae = True
-
-    if args.virtualisation:
-        test_sys.have_virtualization = True
-
     test_sys.init_param = args.init_param

     # For now, assign all the CPUs to the same clock domain

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/51007
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I4d631561d62399b946106a90c14454115040c206
Gerrit-Change-Number: 51007
Gerrit-PatchSet: 2
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to