Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/51831 )

 (

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one. )Change subject: cpu: Move FuncUnit.py, its .cc and StaticInstFlags.py above Return.
......................................................................

cpu: Move FuncUnit.py, its .cc and StaticInstFlags.py above Return.

These two files can be used even with the NULL ISA since they don't
depend on anything that would require a NULL ISA specific definition.

Change-Id: Ie7d83fccf39218c40bd741c76a1c6c0ac7fe2f87
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/51831
Reviewed-by: Jason Lowe-Power <power...@gmail.com>
Maintainer: Jason Lowe-Power <power...@gmail.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/cpu/SConscript
1 file changed, 20 insertions(+), 3 deletions(-)

Approvals:
  Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
  kokoro: Regressions pass




diff --git a/src/cpu/SConscript b/src/cpu/SConscript
index f5b67d1..0aaca12 100644
--- a/src/cpu/SConscript
+++ b/src/cpu/SConscript
@@ -79,8 +79,12 @@
     'ExecFaulting', 'ExecUser', 'ExecKernel' ])
 CompoundFlag('ExecNoTicks', [ 'Exec', 'FmtTicksOff' ])

+Source('func_unit.cc')
 Source('pc_event.cc')

+SimObject('FuncUnit.py')
+SimObject('StaticInstFlags.py')
+
 if env['TARGET_ISA'] == 'null':
     Return()

@@ -93,13 +97,11 @@

 SimObject('BaseCPU.py')
 SimObject('CPUTracers.py')
-SimObject('FuncUnit.py')
 SimObject('TimingExpr.py')

 Source('activity.cc')
 Source('base.cc')
 Source('exetrace.cc')
-Source('func_unit.cc')
 Source('inteltrace.cc')
 Source('nativetrace.cc')
 Source('nop_static_inst.cc')
@@ -113,6 +115,5 @@
 Source('timing_expr.cc')

 SimObject('DummyChecker.py')
-SimObject('StaticInstFlags.py')
 Source('checker/cpu.cc')
 DebugFlag('Checker')

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/51831
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ie7d83fccf39218c40bd741c76a1c6c0ac7fe2f87
Gerrit-Change-Number: 51831
Gerrit-PatchSet: 3
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-Reviewer: Bobby R. Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Daniel Carvalho <oda...@yahoo.com.br>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-Reviewer: Jason Lowe-Power <power...@gmail.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to