Bobby R. Bruce has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/52843 )
Change subject: stdlib: Fix component incorporation ordering
......................................................................
stdlib: Fix component incorporation ordering
Running with KVM cores was not possible with the previous ordering. The
processor must be incorporated after the cache hierarchy when using a
KVM core. A more detailed account of this bug is noted here:
https://gem5.atlassian.net/browse/GEM5-1113
This patch only partially fixes the problem. Ideally the component
incorporation order should not cause problems.
Change-Id: I4bb69ffe7963ba3708458cff7f2b09e9e75830a7
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/52843
Reviewed-by: Jason Lowe-Power <power...@gmail.com>
Maintainer: Jason Lowe-Power <power...@gmail.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/python/gem5/components/boards/abstract_board.py
1 file changed, 33 insertions(+), 5 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/python/gem5/components/boards/abstract_board.py
b/src/python/gem5/components/boards/abstract_board.py
index 9bfac8f..4055e17 100644
--- a/src/python/gem5/components/boards/abstract_board.py
+++ b/src/python/gem5/components/boards/abstract_board.py
@@ -234,17 +234,24 @@
The order of this board is always:
1. Connect the memory.
- 2. Connect the processor.
- 3. Connect the cache hierarchy.
+ 2. Connect the cache hierarchy.
+ 3. Connect the processor.
Developers may build upon this assumption when creating components.
+
+ Notes
+ -----
+
+ * The processor is incorporated after the cache hierarchy due to a
bug
+ noted here: https://gem5.atlassian.net/browse/GEM5-1113. Until this
+ bug is fixed, this ordering must be maintained.
"""
# Incorporate the memory into the motherboard.
self.get_memory().incorporate_memory(self)
- # Incorporate the processor into the motherboard.
- self.get_processor().incorporate_processor(self)
-
# Incorporate the cache hierarchy for the motherboard.
self.get_cache_hierarchy().incorporate_cache(self)
+
+ # Incorporate the processor into the motherboard.
+ self.get_processor().incorporate_processor(self)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/52843
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I4bb69ffe7963ba3708458cff7f2b09e9e75830a7
Gerrit-Change-Number: 52843
Gerrit-PatchSet: 4
Gerrit-Owner: Bobby R. Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Bobby R. Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Jason Lowe-Power <power...@gmail.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
