Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/52060 )
(
14 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
)Change subject: cpu: Eliminate the ThreadContext::setNPC method.
......................................................................
cpu: Eliminate the ThreadContext::setNPC method.
It is no longer used.
Change-Id: Ic0526097550b109455cb09707e712775a0be56c4
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/52060
Tested-by: kokoro <noreply+kok...@google.com>
Reviewed-by: Daniel Carvalho <oda...@yahoo.com.br>
Maintainer: Gabe Black <gabe.bl...@gmail.com>
---
M src/cpu/thread_context.hh
M src/cpu/checker/thread_context.hh
2 files changed, 15 insertions(+), 15 deletions(-)
Approvals:
Daniel Carvalho: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/cpu/checker/thread_context.hh
b/src/cpu/checker/thread_context.hh
index b210fea..dfc9524 100644
--- a/src/cpu/checker/thread_context.hh
+++ b/src/cpu/checker/thread_context.hh
@@ -335,13 +335,6 @@
}
void
- setNPC(Addr val)
- {
- checkerTC->setNPC(val);
- actualTC->setNPC(val);
- }
-
- void
pcStateNoRecord(const PCStateBase &val) override
{
return actualTC->pcState(val);
diff --git a/src/cpu/thread_context.hh b/src/cpu/thread_context.hh
index 9e4d495..07eb7bb 100644
--- a/src/cpu/thread_context.hh
+++ b/src/cpu/thread_context.hh
@@ -233,14 +233,6 @@
pcState(*new_pc);
}
- void
- setNPC(Addr val)
- {
- std::unique_ptr<PCStateBase> pc_state(pcState().clone());
- pc_state->as<TheISA::PCState>().setNPC(val);
- pcState(*pc_state);
- }
-
virtual void pcStateNoRecord(const PCStateBase &val) = 0;
virtual Addr instAddr() const = 0;
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/52060
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ic0526097550b109455cb09707e712775a0be56c4
Gerrit-Change-Number: 52060
Gerrit-PatchSet: 16
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Daniel Carvalho <oda...@yahoo.com.br>
Gerrit-Reviewer: Earl Ou <shunhsin...@google.com>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
