Mahyar Samani has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/53164 )
(
8 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
)Change subject: test: Updating simple_traffic_run and adding tests
......................................................................
test: Updating simple_traffic_run and adding tests
This change updates simple_traffic_run.py with adding clock_domain
for GUPSGen based generators. Also the tests that resulted in
error before are now fixed and added.
Change-Id: I992898a3aef509afd9dec1f9b5d14c5fd67cff37
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/53164
Reviewed-by: Bobby Bruce <bbr...@ucdavis.edu>
Maintainer: Bobby Bruce <bbr...@ucdavis.edu>
Tested-by: kokoro <noreply+kok...@google.com>
---
M tests/gem5/traffic_gen/simple_traffic_run.py
M tests/gem5/traffic_gen/test_memory_traffic_gen.py
2 files changed, 24 insertions(+), 7 deletions(-)
Approvals:
Bobby Bruce: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/tests/gem5/traffic_gen/simple_traffic_run.py
b/tests/gem5/traffic_gen/simple_traffic_run.py
index 5230045..ede4993 100644
--- a/tests/gem5/traffic_gen/simple_traffic_run.py
+++ b/tests/gem5/traffic_gen/simple_traffic_run.py
@@ -35,7 +35,6 @@
import argparse
import importlib
-from os.path import join
from m5.objects import Root, MemorySize
from gem5.components.boards.test_board import TestBoard
@@ -71,15 +70,18 @@
from gem5.components.processors.gups_generator import GUPSGenerator
table_size = f"{int(mem_size / 2)}B"
- return GUPSGenerator(0, table_size, update_limit=1000)
+ return GUPSGenerator(
+ 0, table_size, update_limit=1000, clk_freq="2GHz"
+ )
elif generator_class == "GUPSGeneratorEP":
from gem5.components.processors.gups_generator_ep import (
GUPSGeneratorEP,
)
table_size = f"{int(mem_size / 2)}B"
+
return GUPSGeneratorEP(
- generator_cores, 0, table_size, update_limit=1000
+ generator_cores, 0, table_size, update_limit=1000,
clk_freq="2GHz"
)
elif generator_class == "GUPSGeneratorPAR":
from gem5.components.processors.gups_generator_par import (
@@ -88,7 +90,7 @@
table_size = f"{int(mem_size / 2)}B"
return GUPSGeneratorPAR(
- generator_cores, 0, table_size, update_limit=1000
+ generator_cores, 0, table_size, update_limit=1000,
clk_freq="2GHz"
)
else:
raise ValueError(f"Unknown generator class {generator_class}")
diff --git a/tests/gem5/traffic_gen/test_memory_traffic_gen.py
b/tests/gem5/traffic_gen/test_memory_traffic_gen.py
index e5126ba..13b4638 100644
--- a/tests/gem5/traffic_gen/test_memory_traffic_gen.py
+++ b/tests/gem5/traffic_gen/test_memory_traffic_gen.py
@@ -106,9 +106,7 @@
def create_single_core_tests(module, memory_classes):
- # TODO: Add GUPSGenerator to these tests after adding ClockDomain as
- # an input parameter.
- generator_classes = ["LinearGenerator", "RandomGenerator"]
+ generator_classes =
["LinearGenerator", "RandomGenerator", "GUPSGenerator"]
for generator_class in generator_classes:
for cache_class in cache_classes:
for memory_class in memory_classes:
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/53164
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I992898a3aef509afd9dec1f9b5d14c5fd67cff37
Gerrit-Change-Number: 53164
Gerrit-PatchSet: 10
Gerrit-Owner: Mahyar Samani <msam...@ucdavis.edu>
Gerrit-Reviewer: Bobby Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Jason Lowe-Power <power...@gmail.com>
Gerrit-Reviewer: Mahyar Samani <msam...@ucdavis.edu>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
