Matthew Poremba has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/53063 )

Change subject: dev-amdgpu: Hotfix variable initialization
......................................................................

dev-amdgpu: Hotfix variable initialization

These non-initialized variables were causing the trace reader not to
record all lines.

Change-Id: I88764493d8124c072bc90ff9c08aa26421467f7b
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/53063
Reviewed-by: Matt Sinclair <mattdsincl...@gmail.com>
Maintainer: Matt Sinclair <mattdsincl...@gmail.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/dev/amdgpu/mmio_reader.hh
1 file changed, 19 insertions(+), 3 deletions(-)

Approvals:
  Matt Sinclair: Looks good to me, approved; Looks good to me, approved
  kokoro: Regressions pass




diff --git a/src/dev/amdgpu/mmio_reader.hh b/src/dev/amdgpu/mmio_reader.hh
index 6c88f0b..a057183 100644
--- a/src/dev/amdgpu/mmio_reader.hh
+++ b/src/dev/amdgpu/mmio_reader.hh
@@ -99,9 +99,9 @@
     trace_BAR_t trace_BARs[6];

     /* Indexes used to print driver loading progress. */
-    uint64_t trace_index;
-    uint64_t trace_final_index;
-    uint64_t trace_cur_index;
+    uint64_t trace_index = 0;
+    uint64_t trace_final_index = 0;
+    uint64_t trace_cur_index = 0;

     /* An entry in the MMIO trace. */
     struct MmioTrace

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/53063
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I88764493d8124c072bc90ff9c08aa26421467f7b
Gerrit-Change-Number: 53063
Gerrit-PatchSet: 2
Gerrit-Owner: Alexandru Duțu <alexandru.d...@amd.com>
Gerrit-Reviewer: Matt Sinclair <mattdsincl...@gmail.com>
Gerrit-Reviewer: Matthew Poremba <matthew.pore...@amd.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to