Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/49419 )
(
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
)Change subject: scons: Remove a workaround for a very old SCons bug.
......................................................................
scons: Remove a workaround for a very old SCons bug.
I can't conclusively verify that this issue has been fixed because I
can't find any information about it on the internet. It's "SCons bug
2006" and "gem5 bug 308" but neither project still uses whatever bug
tracking mechanism those numbers correspond to. The change was mentioned
in the gem5 code base at least as early as 2008, and so hopefully has
been fixed in the last 13 years. I did a clean build without this
workaround, and things seem to work.
Change-Id: I155f0e72cb720fb5d35d8098375a45a69ea02263
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/49419
Maintainer: Gabe Black <gabe.bl...@gmail.com>
Reviewed-by: Andreas Sandberg <andreas.sandb...@arm.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/SConscript
1 file changed, 21 insertions(+), 5 deletions(-)
Approvals:
Andreas Sandberg: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/SConscript b/src/SConscript
index c514fc7..b19c3c5 100644
--- a/src/SConscript
+++ b/src/SConscript
@@ -432,11 +432,6 @@
for extra_dir in extras_dir_list:
env.Append(CPPPATH=Dir(extra_dir))
-# Workaround for bug in SCons version > 0.97d20071212
-# Scons bug id: 2006 gem5 Bug id: 308
-for root, dirs, files in os.walk(base_dir, topdown=True):
- Dir(root[len(base_dir) + 1:])
-
########################################################################
#
# Walk the tree and execute all SConscripts in subdirectories
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/49419
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I155f0e72cb720fb5d35d8098375a45a69ea02263
Gerrit-Change-Number: 49419
Gerrit-PatchSet: 33
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
