Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/56184 )

Change subject: arch-arm: Don't check validKvmEnvironment in the KVM GIC.
......................................................................

arch-arm: Don't check validKvmEnvironment in the KVM GIC.

If a KvmVM is present, then we know there is a valid environment. If
kernelGic is not null, then we know there was a kvmVM. Therefore, if the
kernelGic is not null, we know the environment is valid, and so that
extra check is redundant.

Change-Id: If0d929ecdeec335ccdbf5f83af9e12b6ac915168
---
M src/arch/arm/kvm/gic.cc
1 file changed, 16 insertions(+), 2 deletions(-)



diff --git a/src/arch/arm/kvm/gic.cc b/src/arch/arm/kvm/gic.cc
index ac7a7f5..300ea0f 100644
--- a/src/arch/arm/kvm/gic.cc
+++ b/src/arch/arm/kvm/gic.cc
@@ -188,7 +188,7 @@
 MuxingKvmGic::startup()
 {
     GicV2::startup();
-    usingKvm = (kernelGic != nullptr) && system.validKvmEnvironment();
+    usingKvm = (kernelGic != nullptr);
     if (usingKvm)
         fromGicV2ToKvm();
 }
@@ -205,7 +205,7 @@
 MuxingKvmGic::drainResume()
 {
     GicV2::drainResume();
-    bool use_kvm = (kernelGic != nullptr) && system.validKvmEnvironment();
+    bool use_kvm = (kernelGic != nullptr);
     if (use_kvm != usingKvm) {
         // Should only occur due to CPU switches
         if (use_kvm) // from simulation to KVM emulation

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/56184
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: If0d929ecdeec335ccdbf5f83af9e12b6ac915168
Gerrit-Change-Number: 56184
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to