Hoa Nguyen has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/56989 )
Change subject: mem-cache: Fix stats in src/mem/cache/base.cc
......................................................................
mem-cache: Fix stats in src/mem/cache/base.cc
Most latency stats are described to have a unit of Tick.
However, the unit should be cycles.
Change-Id: Ib1b9b7c6fa4404cecb3982b3799753df19774623
Signed-off-by: Hoa Nguyen <hoangu...@ucdavis.edu>
---
M src/mem/cache/base.cc
1 file changed, 39 insertions(+), 25 deletions(-)
diff --git a/src/mem/cache/base.cc b/src/mem/cache/base.cc
index 435684a..bfdce0c 100644
--- a/src/mem/cache/base.cc
+++ b/src/mem/cache/base.cc
@@ -2028,16 +2028,16 @@
("number of " + name + " hits").c_str()),
ADD_STAT(misses, statistics::units::Count::get(),
("number of " + name + " misses").c_str()),
- ADD_STAT(hitLatency, statistics::units::Tick::get(),
- ("number of " + name + " hit ticks").c_str()),
- ADD_STAT(missLatency, statistics::units::Tick::get(),
- ("number of " + name + " miss ticks").c_str()),
+ ADD_STAT(hitLatency, statistics::units::Cycle::get(),
+ ("number of " + name + " hit cycles").c_str()),
+ ADD_STAT(missLatency, statistics::units::Cycle::get(),
+ ("number of " + name + " miss cycles").c_str()),
ADD_STAT(accesses, statistics::units::Count::get(),
("number of " + name + " accesses(hits+misses)").c_str()),
ADD_STAT(missRate, statistics::units::Ratio::get(),
("miss rate for " + name + " accesses").c_str()),
ADD_STAT(avgMissLatency, statistics::units::Rate<
- statistics::units::Tick,
statistics::units::Count>::get(),
+ statistics::units::Cycle,
statistics::units::Count>::get(),
("average " + name + " miss latency").c_str()),
ADD_STAT(mshrHits, statistics::units::Count::get(),
("number of " + name + " MSHR hits").c_str()),
@@ -2045,17 +2045,17 @@
("number of " + name + " MSHR misses").c_str()),
ADD_STAT(mshrUncacheable, statistics::units::Count::get(),
("number of " + name + " MSHR uncacheable").c_str()),
- ADD_STAT(mshrMissLatency, statistics::units::Tick::get(),
- ("number of " + name + " MSHR miss ticks").c_str()),
- ADD_STAT(mshrUncacheableLatency, statistics::units::Tick::get(),
- ("number of " + name + " MSHR uncacheable ticks").c_str()),
+ ADD_STAT(mshrMissLatency, statistics::units::Cycle::get(),
+ ("number of " + name + " MSHR miss cycles").c_str()),
+ ADD_STAT(mshrUncacheableLatency, statistics::units::Cycle::get(),
+ ("number of " + name + " MSHR uncacheable cycles").c_str()),
ADD_STAT(mshrMissRate, statistics::units::Ratio::get(),
("mshr miss rate for " + name + " accesses").c_str()),
ADD_STAT(avgMshrMissLatency, statistics::units::Rate<
- statistics::units::Tick,
statistics::units::Count>::get(),
+ statistics::units::Cycle,
statistics::units::Count>::get(),
("average " + name + " mshr miss latency").c_str()),
ADD_STAT(avgMshrUncacheableLatency, statistics::units::Rate<
- statistics::units::Tick,
statistics::units::Count>::get(),
+ statistics::units::Cycle,
statistics::units::Count>::get(),
("average " + name + " mshr uncacheable latency").c_str())
{
}
@@ -2201,18 +2201,18 @@
"number of demand (read+write) hits"),
ADD_STAT(overallHits, statistics::units::Count::get(),
"number of overall hits"),
- ADD_STAT(demandHitLatency, statistics::units::Tick::get(),
- "number of demand (read+write) hit ticks"),
- ADD_STAT(overallHitLatency, statistics::units::Tick::get(),
- "number of overall hit ticks"),
+ ADD_STAT(demandHitLatency, statistics::units::Cycle::get(),
+ "number of demand (read+write) hit cycles"),
+ ADD_STAT(overallHitLatency, statistics::units::Cycle::get(),
+ "number of overall hit cycles"),
ADD_STAT(demandMisses, statistics::units::Count::get(),
"number of demand (read+write) misses"),
ADD_STAT(overallMisses, statistics::units::Count::get(),
"number of overall misses"),
- ADD_STAT(demandMissLatency, statistics::units::Tick::get(),
- "number of demand (read+write) miss ticks"),
- ADD_STAT(overallMissLatency, statistics::units::Tick::get(),
- "number of overall miss ticks"),
+ ADD_STAT(demandMissLatency, statistics::units::Cycle::get(),
+ "number of demand (read+write) miss cycles"),
+ ADD_STAT(overallMissLatency, statistics::units::Cycle::get(),
+ "number of overall miss cycles"),
ADD_STAT(demandAccesses, statistics::units::Count::get(),
"number of demand (read+write) accesses"),
ADD_STAT(overallAccesses, statistics::units::Count::get(),
@@ -2246,12 +2246,12 @@
"number of overall MSHR misses"),
ADD_STAT(overallMshrUncacheable, statistics::units::Count::get(),
"number of overall MSHR uncacheable misses"),
- ADD_STAT(demandMshrMissLatency, statistics::units::Tick::get(),
- "number of demand (read+write) MSHR miss ticks"),
- ADD_STAT(overallMshrMissLatency, statistics::units::Tick::get(),
- "number of overall MSHR miss ticks"),
- ADD_STAT(overallMshrUncacheableLatency, statistics::units::Tick::get(),
- "number of overall MSHR uncacheable ticks"),
+ ADD_STAT(demandMshrMissLatency, statistics::units::Cycle::get(),
+ "number of demand (read+write) MSHR miss cycles"),
+ ADD_STAT(overallMshrMissLatency, statistics::units::Cycle::get(),
+ "number of overall MSHR miss cycles"),
+ ADD_STAT(overallMshrUncacheableLatency,
statistics::units::Cycle::get(),
+ "number of overall MSHR uncacheable cycles"),
ADD_STAT(demandMshrMissRate, statistics::units::Ratio::get(),
"mshr miss ratio for demand accesses"),
ADD_STAT(overallMshrMissRate, statistics::units::Ratio::get(),
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/56989
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ib1b9b7c6fa4404cecb3982b3799753df19774623
Gerrit-Change-Number: 56989
Gerrit-PatchSet: 1
Gerrit-Owner: Hoa Nguyen <hoangu...@ucdavis.edu>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
