Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/57014 )
Change subject: dev: Fix the size of the config space for the IDE
controller.
......................................................................
dev: Fix the size of the config space for the IDE controller.
The PCI_CONFIG_SIZE constant isn't really a size, it's actually a mask.
When using it to size the IDE controller config space, we need to add 1.
Change-Id: I4aa6c0a488ac3dc1977a95d36423160a4bdda133
---
M src/dev/storage/ide_ctrl.hh
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/src/dev/storage/ide_ctrl.hh b/src/dev/storage/ide_ctrl.hh
index 38b97bf..635c446 100644
--- a/src/dev/storage/ide_ctrl.hh
+++ b/src/dev/storage/ide_ctrl.hh
@@ -96,7 +96,9 @@
/* 0x48 */ Register8 udmaControl = {"udma control"};
/* 0x49 */ RegisterRaz raz1 = {"raz1", 1};
/* 0x4a-0x4b */ Register16 udmaTiming = {"udma timing"};
- /* 0x4c-... */ RegisterRaz raz2 = {"raz2", PCI_CONFIG_SIZE -
0x4c};
+ // PCI_CONFIG_SIZE is really a mask and not a size, so we add one.
+ /* 0x4c-... */ RegisterRaz raz2 =
+ {"raz2", (PCI_CONFIG_SIZE + 1) - 0x4c};
void serialize(CheckpointOut &cp) const;
void unserialize(CheckpointIn &cp);
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/57014
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I4aa6c0a488ac3dc1977a95d36423160a4bdda133
Gerrit-Change-Number: 57014
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
